Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to only include specific txs in a benchmark #5445

Closed
alexghr opened this issue Mar 26, 2024 · 0 comments
Closed

Add mechanism to only include specific txs in a benchmark #5445

alexghr opened this issue Mar 26, 2024 · 0 comments

Comments

@alexghr
Copy link
Contributor

alexghr commented Mar 26, 2024

We need a way to benchmark specific txs in order to control how much processing time and data they require.

In #5414 we've added benchmarks for tx size but to be accurate they require very specific txs otherwise the data from other benchmarks or even the test setup could lead to comparing apples and oranges.

I think the ideal case would be to "tag" test transactions in a specific way, e.g.:

await testContract.methods.transfer(alice, bob, 1n, 0).send({
  metricsTag: "tx_size_comparison"
}).wait()

And the metrics logs to pick up these tags when they're captured

@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 26, 2024
@PhilWindle PhilWindle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 27, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants