Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM: Spike: Do we implement block limit opcodes? #4300

Closed
Tracked by #3383
, #7116
...
Maddiaa0 opened this issue Jan 30, 2024 · 1 comment
Closed
Tracked by #3383
, #7116
...

AVM: Spike: Do we implement block limit opcodes? #4300

Maddiaa0 opened this issue Jan 30, 2024 · 1 comment
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Jan 30, 2024 •
edited
Loading

Overview

When implementing the #4124 issue, it was not clear whether we really needed the following opcodes:

  • BlockL1GasLimit
  • BlockL2GasLimit
  • BlockDaGasLimit

I think it is very unlikely that these opcodes are required, we will have to conduct an analysis of ethereum contracts to deteremine how many include the gasLimit opcode

Outcome

Conduct a review determining whether it makes sense to include these instructions within our instruction set.

Links
@Maddiaa0 Maddiaa0 mentioned this issue Jan 30, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 30, 2024
@Maddiaa0 Maddiaa0 mentioned this issue Jan 30, 2024
Closed
@dbanks12 dbanks12 added this to the AVM Simulator Phase 2 (full) milestone Jan 30, 2024
@Maddiaa0 Maddiaa0 added the C-avm Component: AVM related tickets (aka public VM) label Jan 30, 2024
@dbanks12 dbanks12 changed the title public-vm(decision): Do we implement block limit opcodes AVM: Spike: Do we implement block limit opcodes? Jun 19, 2024
@dbanks12 dbanks12 mentioned this issue Jun 19, 2024
Closed
@dbanks12 dbanks12 removed this from the AVM Simulator Phase 2 (full) milestone Jun 19, 2024
@dbanks12
Copy link
Collaborator

dbanks12 commented Oct 1, 2024

Not implementing block limit opcodes

@dbanks12 dbanks12 closed this as completed Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbanks12 @Maddiaa0