Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barretenberg nightly build failing #1838

Closed
kevaundray opened this issue Aug 27, 2023 · 1 comment
Closed

barretenberg nightly build failing #1838

kevaundray opened this issue Aug 27, 2023 · 1 comment
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

Problem

Barretenberg releases nightly builds each day, however these are currently failing due to npm publish not being idempotent.

The releases use the same workflow as publishing, and as a part of publishing, we push packages to npm. Since the version number in package.json may not change each night, it will cause the workflow to fail.

Solution

Short term

  • Not publish to npm when running nightly builds

Long term

  • Publish to npm and tag each version with the timestamp.
  • Also possibly add a cron job each month that removes all npm releases that are more than a month old.
@kevaundray kevaundray added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 27, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 27, 2023
@kevaundray
Copy link
Contributor Author

I've added a skip if nightly clause in #1837 -- leaving this open because we ideally want to get nightly builds of the bb.js packages too

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
Archived in project
Development

No branches or pull requests

2 participants