Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting Fr where AztecAddressLike is expected is a footgun #11343

Closed
olehmisar opened this issue Jan 20, 2025 · 0 comments · Fixed by #11350
Closed

Accepting Fr where AztecAddressLike is expected is a footgun #11343

olehmisar opened this issue Jan 20, 2025 · 0 comments · Fixed by #11350
Assignees

Comments

@olehmisar
Copy link
Contributor

olehmisar commented Jan 20, 2025

E.g., I can accidentally pass amount where to is expected in token transfer methods.

To fix: remove | Fr from type AztecAddressLike

export type AztecAddressLike = { /** Wrapped address */ address: FieldLike } | AztecAddress | Fr;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants