Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument json-rpc server and json-rpc client and capture appropriate metrics #11185

Closed
alexghr opened this issue Jan 13, 2025 · 0 comments · Fixed by #11325
Closed

Instrument json-rpc server and json-rpc client and capture appropriate metrics #11185

alexghr opened this issue Jan 13, 2025 · 0 comments · Fixed by #11325
Assignees

Comments

@alexghr
Copy link
Contributor

alexghr commented Jan 13, 2025

Add instrumentation to the JSON-RPC layer:

Server:

metric type attributes
number of requests counter service name (e.g. node, pxe, prover node), rpc method (e.g. getTips)
number of errors counter service name, rpc method
rpc duration histogram service name, rpc method
request span span link against parent span from client

Client:

metric type attributes
number of requests counter host, service name, rpc method (e.g. getTips)
number of errors counter host, service name, rpc method
request size in bytes gauge host, service name, rpc method
response size in bytes gauge host, service name, rpc method
rpc duration histogram host, service name, rpc method
request span span link against parent span from client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant