fix: add log severity #10835
Merged
fix: add log severity #10835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
approved these changes
Dec 18, 2024
Comment on lines
80
to
86
| case 'debug': | ||
| case 'verbose': | ||
| severity = 'DEBUG'; | ||
| break; | ||
| case 'info': | ||
| severity = 'INFO'; | ||
| break; |
There was a problem hiding this comment.
WDYT about mapping debug to DEBUG, verbose to INFO, and info to NOTICE, so we keep that extra granularity? It may be confusing that our infos get propagated as notice instead of info though...
Comment on lines
+108
to
+110
| formatters: { | ||
| level: levelToSeverityFormatter, | ||
| }, |
There was a problem hiding this comment.
Is there a way to apply this formatter to the stdio transport only? We don't need to make this change in the OTEL transport.
There was a problem hiding this comment.
According to the pino docs, no. But I'm not sure if that means we can't customize the log level at all or if we can't customize it per transport.
https://github.com/pinojs/pino/blob/main/docs/api.md#level
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to get log levels recognized by Google's Log Explorer service