Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blobs): remove checkBlob flag in Rollup.sol #10147

Open
Tracked by #8955
MirandaWood opened this issue Nov 22, 2024 · 0 comments
Open
Tracked by #8955

feat(blobs): remove checkBlob flag in Rollup.sol #10147

MirandaWood opened this issue Nov 22, 2024 · 0 comments

Comments

@MirandaWood
Copy link
Contributor

We currently have a contract level checkBlob = true flag in Rollup.sol for testing and simulating txs. It exists mainly because viem does not allow sending blob sidecars when simulating txs, so any simulated tx will fail with incorrect blob hashes. We instead override the checkBlob state so a simulation will actually run. See l1-publisher.ts for more details.
Ideally we would be able to simulate txs with blob sidecars and remove this flag.
@MirandaWood MirandaWood mentioned this issue Nov 22, 2024
Merged
@MirandaWood MirandaWood changed the title Remove checkBlob flag in Rollup.sol feat(blobs): remove checkBlob flag in Rollup.sol Nov 30, 2024
@MirandaWood MirandaWood mentioned this issue Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MirandaWood