Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate and unused flavor related concepts #10035

Merged
merged 1 commit into from
Nov 19, 2024
Merged

chore: remove duplicate and unused flavor related concepts #10035

merged 1 commit into from
Nov 19, 2024

Conversation

maramihali
Copy link
Contributor

@maramihali maramihali commented Nov 19, 2024 •
edited
Loading

We had two duplicate concepts pointing to the same set of types as well as some unused instantiations (we are not folding Ultra keys).

@maramihali maramihali self-assigned this Nov 19, 2024
@maramihali maramihali added the crypto cryptography label Nov 19, 2024
@iakovenkos iakovenkos self-requested a review November 19, 2024 15:50
iakovenkos
iakovenkos approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@iakovenkos iakovenkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clean-up!

@maramihali maramihali merged commit 30ca68c into master Nov 19, 2024
50 of 91 checks passed
@maramihali maramihali deleted the mm/flavor-cleanup branch November 19, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iakovenkos iakovenkos iakovenkos approved these changes

Assignees

@maramihali maramihali

Labels
crypto cryptography
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maramihali @iakovenkos