From 36fff222ab9fd0ba2124208f5868a63c9ead0569 Mon Sep 17 00:00:00 2001 From: Tom French <15848336+TomAFrench@users.noreply.github.com> Date: Mon, 9 Dec 2024 18:19:48 +0000 Subject: [PATCH] Apply suggestions from code review --- noir/noir-repo/acvm-repo/acvm/src/compiler/mod.rs | 2 +- noir/noir-repo/tooling/nargo_cli/src/cli/compile_cmd.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/noir/noir-repo/acvm-repo/acvm/src/compiler/mod.rs b/noir/noir-repo/acvm-repo/acvm/src/compiler/mod.rs index e32c0665c0f..ff340fb5bcd 100644 --- a/noir/noir-repo/acvm-repo/acvm/src/compiler/mod.rs +++ b/noir/noir-repo/acvm-repo/acvm/src/compiler/mod.rs @@ -18,7 +18,7 @@ pub use transformers::{transform, MIN_EXPRESSION_WIDTH}; /// We need multiple passes to stabilize the output. /// The value was determined by running tests. -const MAX_OPTIMIZER_PASSES: usize = 3; +const MAX_OPTIMIZER_PASSES: usize = 1; /// This module moves and decomposes acir opcodes. The transformation map allows consumers of this module to map /// metadata they had about the opcodes to the new opcode structure generated after the transformation. diff --git a/noir/noir-repo/tooling/nargo_cli/src/cli/compile_cmd.rs b/noir/noir-repo/tooling/nargo_cli/src/cli/compile_cmd.rs index f134374f89e..7be00ada459 100644 --- a/noir/noir-repo/tooling/nargo_cli/src/cli/compile_cmd.rs +++ b/noir/noir-repo/tooling/nargo_cli/src/cli/compile_cmd.rs @@ -384,6 +384,7 @@ mod tests { /// This test is here purely because of the convenience of having access to /// the utility functions to process workspaces. #[test] + #[ignore] fn test_transform_program_is_idempotent() { let opts = Options::parse();