From fbe4568d85201dcc90a59bd4eaae9f564ed1b41c Mon Sep 17 00:00:00 2001 From: Mattias Axelsson Date: Tue, 30 Apr 2024 14:51:55 +0200 Subject: [PATCH] Log missing TLS certificates as a warning rather than an error TLS is enabled by default and uploading certificates over HTTP needs to happen after the application has started, so the user cannot avoid this message when using HTTP rather than SSH. The warning message already exists in tls_log_missing_cert_certs(), so this change only removes the generic error message at the call site. --- app/dockerdwrapper.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/dockerdwrapper.c b/app/dockerdwrapper.c index 0f93293..17ed89f 100644 --- a/app/dockerdwrapper.c +++ b/app/dockerdwrapper.c @@ -412,12 +412,8 @@ static bool read_settings(struct settings* settings, const struct app_state* app // when TCP won't be used. If the setting is changed we will loop through // this function again. settings->use_tls = false; - else { - if (!get_and_verify_tls_selection(param_handle, &settings->use_tls)) { - log_error("Failed to verify tls selection"); - return false; - } - } + else if (!get_and_verify_tls_selection(param_handle, &settings->use_tls)) + return false; settings->use_ipc_socket = is_parameter_yes(param_handle, PARAM_IPC_SOCKET);