upgrade project to typescript #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debaerdm
added
component
configuration
dependencies
Fcornaire
approved these changes
Aug 13, 2020
|
SonarCloud Quality Gate failed.
|
Fcornaire
approved these changes
Aug 21, 2020
hamzahamidi
reviewed
Aug 21, 2020
gui260586
approved these changes
Aug 21, 2020
hamzahamidi
approved these changes
Aug 21, 2020
|
|
||
| const createPreprocessors = require('./svelte.config').createPreprocessors; | ||
| const production = !process.env.ROLLUP_WATCH; |
There was a problem hiding this comment.
The ROLLUP_WATCH environment variable is about watch mode not production 😃 . You could use process.env.NODE_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
PR Description
upgrade project to typescript