fixes to sharing modal and enable for English users #77053
Conversation
This reverts commit ee0c579.
…eration clearer between ETK and calypso
matticbot
added
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
| @@ -30,6 +32,9 @@ const SharingModal: React.FC = () => { | |||
| const { launchpadScreenOption } = window?.launchpadOptions || {}; | |||
| const { isDismissed, updateIsDismissed } = useSharingModalDismissed( isDismissedDefault ); | |||
| const { __ } = useI18n(); | |||
| const localeSlug = useLocale(); | |||
| const isEnglish = localeSlug?.startsWith( 'en' ); | |||
| const isPrivateBlog = window?.wpcomGutenberg?.blogPublic === '-1'; | |||
There was a problem hiding this comment.
I don't see how this will block on P2. If the P2 is public, I think it will still show.. is that ok?
There was a problem hiding this comment.
I suspect that is fine. I suspect the primary issue is to not show it on private blogs and P2s since you'd never really want to promote private posts.
There was a problem hiding this comment.
Yeah, if p2 is public the share modal pops up. Think that's ok but just wanted to double check;
There was a problem hiding this comment.
I suspect the primary issue is to not show it on private blogs and P2s since you'd never really want to promote private posts.
Yeah, if p2 is public the share modal pops up. Think that's ok
I agree here as well. 👍
There was a problem hiding this comment.
yep, I didn't even think about P2s being public but I agree that the thing we care about is private blogs. A public P2 would probably want to share and if not they can dismiss it.
|
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
github-actions
bot
removed
the
[Status] Needs Review
I had some issues on deploying the sharing modal last time. p1684314937793019-slack-C025Q5RK2
<use>tag does not support loading from external domainsThis PR fixes those two issues and re-enables the sharing modal.
See #76267
The SVG issue required inlining a copy of the social logos svg into the ETK
Testing instructions.
cd apps/editing-toolkit && yarn dev --syncsocial-logos-d55401f99bb02ebd6cf4.svgor similar.