Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Navigation block font color not displaying properly #75196

Closed
tanjoymor opened this issue Apr 1, 2023 · 3 comments
Closed

[Block] Navigation block font color not displaying properly #75196

tanjoymor opened this issue Apr 1, 2023 · 3 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. [Platform] Simple [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@tanjoymor
Copy link

Quick summary

Setting the font color directly on the Navigation block in the Site Editor is not properly reflected on the live site.

Reported in Forums: https://wordpress.com/forums/topic/navigation-menu-text-color-live-not-what-is-set-in-editor/

Steps to reproduce

  1. Existing or new site
  2. Free or Personal plan
  3. Activate theme: Zoologist, Quadrat, Geologist
  4. Go to the Site Editor in edit mode
  5. Select the Navigation block
  6. Set the Text color for the block
  7. Save and view

What you expected to happen

I expected all parent items of the menu to be the color I selected.

What actually happened

Only items that had a sub-item updated to the new color.

Markup 2023-04-01 at 12 29 58

Markup 2023-04-01 at 12 30 17

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

Confirmed it happens on: Zoologist, Quadrat, Geologist
Doesn't happen on: Appleton, Meraki, Russell

Work around: add a sub-item to each menu item but don't add a new link, and turn off the show arrow option. Live site will update to the correct color without behaving like there are sub-items for the menu.

I haven't tested this on the Premium plan, Atomic sites or self-hosted sites. It is consistently reproducible on Simple sites with the Free or Personal plan.

Other findings:
Seems to be coming from this inline CSS that's being added to the index:

<style id='wp-block-navigation-link-inline-css'>
.wp-block-navigation .wp-block-navigation-item__label{overflow-wrap:break-word;word-break:normal}.wp-block-navigation .wp-block-navigation-item__description{display:none}
.wp-block-navigation-link{background-color: transparent;color: var(--wp--custom--color--foreground);}
</style>

Possibly related to: WordPress/gutenberg#42253

@tanjoymor tanjoymor added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Apr 1, 2023
@github-actions github-actions bot added [Platform] Simple [Pri] Low Address when resources are available. labels Apr 1, 2023
@tanjoymor tanjoymor changed the title Zoologist: Navigation block font color not displaying properly [Block] Navigation block font color not displaying properly Apr 1, 2023
@mdtanjid0
Copy link

mdtanjid0 commented Apr 2, 2023

Could replicate the same with Geologist - Slate theme.

6067099-zd ( needs to follow up ).

Looks like this CSS causes that:
Screen Shot 2023-04-02 at 20 03 49

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Support References

This comment is automatically generated. Please do not edit it.

@cuemarie
Copy link

cuemarie commented Apr 4, 2023

@cuemarie cuemarie closed this as completed Apr 4, 2023
@cuemarie cuemarie added [Closed] Duplicate Duplicate of an existing issue. Triaged To be used when issues have been triaged. labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Duplicate Duplicate of an existing issue. [Platform] Simple [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants