Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: change different order in the block transforms menu #67635

Open
simison opened this issue Sep 12, 2022 · 6 comments
Open

Task: change different order in the block transforms menu #67635

simison opened this issue Sep 12, 2022 · 6 comments

Comments

@simison
Copy link
Member

simison commented Sep 12, 2022

Details

Currently “premium content” and “conversation” seem to always appear as the top suggestions in the transforms menu:

image

In many cases, basic core blocks like "columns", "heading", "list", "paragraph" should be suggested first and less frequently used Premium content (and especially" conversations") should be lower in the list.

On an older Atomic site with Business plan:

Screenshot 2022-09-12 at 10 38 16

Screenshot 2022-09-12 at 10 38 04

Screenshot 2022-09-12 at 10 37 54

In above screenshots some other CoBlocks plugin blocks also appear on top, so this could be another core bug like we had before with global styles lists.

Checklist

No response

Related

WordPress/gutenberg#40208

@annezazu
Copy link

Opened an issue about this today -- In Core, we're auditing block transforms WordPress/gutenberg#63635 and I wanted to note how prominent and confusing the paid content transform on WordPress.com is as part of looking across our products. Here's an example from the blog home template on my personal nomad.blog site:

paid.content.transform.mov

I'm curious how effective this is, especially if we have any data, and whether we can make it more specific. For example, it shouldn't appear for a site title or menu but I can understand why it might show up for group blocks. Either way, it's currently taking up precious real estate visually, despite not being a common use case.

@simison
Copy link
Member Author

simison commented Jul 22, 2024

Yeah; leaving the transform appear in top 3 just for container blocks makes sense, and can be lower/below the core blocks for the other blocks.

@simison
Copy link
Member Author

simison commented Jul 22, 2024

@obenland is there a .com team who could tweak the transform priorities on WP.com? See Anne's feedback above.

This could be pretty straightforward.

@simison
Copy link
Member Author

simison commented Jul 26, 2024

Picked this for Zap ⚡

Plan is to see if we can keep showing "convert to paid blocks" only when selecting multiple blocks, OR when not selecting group/columns blocks hides it from menus elsewhere.

Otherwise we can limit to just group/columns blocks using the blocks attribute in transform definitions.

Ideally we'd just push the paid transform down on the list below core blocks, but that might not be possible now in Gutenberg.

Screenshot 2024-07-26 at 18 01 40

@lezama
Copy link
Contributor

lezama commented Jul 31, 2024

I looked into this a bit. Transformations are listed in the order that blocks.registerBlockType calls are made, with an additional orderBy for frecency. It appears that core/blocks are registered after plugin blocks. Generally, I think it would make more sense to register core blocks before plugin blocks.

@simison
Copy link
Member Author

simison commented Jul 31, 2024

It appears that core/blocks are registered after plugin blocks. Generally, I think it would make more sense to register core blocks before plugin blocks.

Any existing Gutenberg issues about this or wanna write a suggestion?

@lezama lezama removed their assignment Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants