Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language picker: focus and select state display bug #43532

Closed
rickybanister opened this issue Jun 22, 2020 · 8 comments
Closed

Language picker: focus and select state display bug #43532

rickybanister opened this issue Jun 22, 2020 · 8 comments
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Task

Comments

@rickybanister
Copy link

When editing your interface language, the focus state and select state for the language buttons clash:

image

We should perhaps use the @wordpress/component focus and select styles (with dotcom colors) for this UI.

@simison
Copy link
Member

simison commented Jun 23, 2020

We should perhaps use the @wordpress/component focus and select styles (with dotcom colors) for this UI.

@Automattic/ganon has core-component version of this UI in the works! 🎉 #43132

It'd be lovely to see a team take that and try move it to Calypso. It would be excellent first step to try core elements in more substantial way in Calypso. cc @griffbrad

@rickybanister
Copy link
Author

That'd be wonderful.

@rickybanister
Copy link
Author

related, we would be able to close this ticket as well: #41938

@ramonjd
Copy link
Member

ramonjd commented Jul 29, 2020

Language picker has been merged (it's behind a feature flag for now as it needs some design eyes and UI tweaks)

#43132

@deBhal deBhal added the [Pri] Normal Schedule for the next available opportuinity. label Oct 26, 2020
@yansern
Copy link
Contributor

yansern commented Feb 3, 2021

Is the feature flag ?flags=gutenboarding/language-picker ready to be removed at this point?
See: pbAok1-dn-p2

@simison
Copy link
Member

simison commented Feb 3, 2021

@yansern I did some testing and looks like it's working well. Let's roll it to production! Thanks for the nudge.

@simison
Copy link
Member

simison commented Feb 8, 2021

This was reverted in #49683

@simison
Copy link
Member

simison commented Feb 11, 2021

I'll close this and have more focused task instead: #49987

@simison simison closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Task
Projects
None yet
Development

No branches or pull requests

6 participants