Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Page Editing: new onboarding route in Horizon #43284

Closed
vindl opened this issue Jun 15, 2020 · 2 comments
Closed

Single Page Editing: new onboarding route in Horizon #43284

vindl opened this issue Jun 15, 2020 · 2 comments

Comments

@vindl
Copy link
Member

vindl commented Jun 15, 2020

We need to provide a different version of Gutenboarding flow that's tailored for FSE. To start that we need either a separate onboarding route in Calypso, or we can use the existing one with the special parameter that will help us differentiate this flow from the default one. This will come in handy in places were we need to conditionally change something in the flow, like navigating to site editor instead of post editor, or displaying a different selection of themes/page layouts.

@vindl vindl changed the title Site Editor: new onboarding route in Horizon Single Page Editing: new onboarding route in Horizon Jun 15, 2020
@ockham
Copy link
Contributor

ockham commented Jun 16, 2020

#43246 is currently doing this via a feature flag (that can be set by appending a ?flags= query arg). We can go with this option for as long as it makes sense, and expand to a separate route if needed. (I'd rather avoid introducing the route right away, since it might lead to some -- currently unnecessary -- duplication of logic between the two flows.)

@vindl
Copy link
Member Author

vindl commented Jun 17, 2020

I think the query arg is completely fine and that we can close this issue.

@vindl vindl closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants