-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varia: Line-height setting isn't respected in the editor #1895
Comments
@kjellr Once this setting lands in WP.com, View squad is expecting to release more than few block patterns using big fonts that take advantage of this setting. I've noticed this is resolved in Varya, but can this be fixed in Varia and the child themes? |
@allancole + @jffng do you think the solution over in Varya could be ported over here pretty easily? |
In Varya, I don't think we did anything special here to handle Gutenberg's new line-height feature, because as of 7.9.1 GB inserts an inline-style: This would override any editor styles, unless |
Ah yes — 7.9.1 hasn't been adopted on WP.com yet because of some other potential conflicts. So it could just be that this will get resolved once that is able to go live. |
Oh, nice. I guess I tested it too soon :D Thanks for the info! |
Gutenberg added the line-height option for paragraph block 🎉The setting is respected on the front-end, but in the editor. It should match with the front-end.
cc: @allancole @ianstewart @alaczek
The text was updated successfully, but these errors were encountered: