Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Line-height setting isn't respected in the editor #1895

Closed
iamtakashi opened this issue Apr 1, 2020 · 5 comments
Closed

Varia: Line-height setting isn't respected in the editor #1895

iamtakashi opened this issue Apr 1, 2020 · 5 comments
Milestone

Comments

@iamtakashi
Copy link
Contributor

Gutenberg added the line-height option for paragraph block 🎉The setting is respected on the front-end, but in the editor. It should match with the front-end.

Screenshot 2020-04-01 at 14 49 48

cc: @allancole @ianstewart @alaczek

@iamtakashi
Copy link
Contributor Author

@kjellr Once this setting lands in WP.com, View squad is expecting to release more than few block patterns using big fonts that take advantage of this setting. I've noticed this is resolved in Varya, but can this be fixed in Varia and the child themes?

@kjellr
Copy link
Contributor

kjellr commented Apr 23, 2020

@allancole + @jffng do you think the solution over in Varya could be ported over here pretty easily?

@jffng
Copy link
Contributor

jffng commented Apr 24, 2020

In Varya, I don't think we did anything special here to handle Gutenberg's new line-height feature, because as of 7.9.1 GB inserts an inline-style:

Screen Shot 2020-04-24 at 12 32 51 PM

This would override any editor styles, unless !important is being set by Varia or the child theme 😄. @iamtakashi am I understanding the problem correctly?

@kjellr
Copy link
Contributor

kjellr commented Apr 24, 2020

Ah yes — 7.9.1 hasn't been adopted on WP.com yet because of some other potential conflicts. So it could just be that this will get resolved once that is able to go live.

@iamtakashi
Copy link
Contributor Author

Oh, nice. I guess I tested it too soon :D Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants