Fix position of the lesson status text #7742
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Automattic/themes#7616
This is the minimalistic solution that addresses the problem.
In different themes, font-size & line-height are different.
Because we position the status div absolutely, its size matters.
In this PR we only fix the line-height. I have an alternative PR that addresses the issue a bit differently: #7743
Course Theme, blue and dark variations before:
![line-height before blue](https://private-user-images.githubusercontent.com/329356/406298451-20f4c34b-b94e-47cb-b166-7017c46e47ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjU1NTMsIm5iZiI6MTczOTQyNTI1MywicGF0aCI6Ii8zMjkzNTYvNDA2Mjk4NDUxLTIwZjRjMzRiLWI5NGUtNDdjYi1iMTY2LTcwMTdjNDZlNDdhZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNTQwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMzdiODc4MWY0ODA1MGRkODZlMGE3MmQxYjY5YzRiZGFhYjM1ZDQzNDBhNjgzNjMwOTkyNzA3NDIxYTEwYTAyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Mzmd7C5HY8BggtR77dfQEyOf61w-1iNOxoVFUmtF2qU)
![line-height before dark](https://private-user-images.githubusercontent.com/329356/406298460-9dc61829-cb21-40af-9166-d4084a08a44e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjU1NTMsIm5iZiI6MTczOTQyNTI1MywicGF0aCI6Ii8zMjkzNTYvNDA2Mjk4NDYwLTlkYzYxODI5LWNiMjEtNDBhZi05MTY2LWQ0MDg0YTA4YTQ0ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNTQwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YjhlZWJmMmI4NmEwYjJjZDM4M2YxYmY5MDJiMjJlN2QzN2Y0ODQzYTAxZjU1M2JlYjVhNTEyZTI1YTMyNDA4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.9GNcYEWdu51GlxJjllJkKqMmmwcsXiB_5j5UUHVu0iA)
Course Theme, blue and dark variations after:
![line-height after blue](https://private-user-images.githubusercontent.com/329356/406298491-ce460e2f-fe25-4193-aec8-ca90800bf9bc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjU1NTMsIm5iZiI6MTczOTQyNTI1MywicGF0aCI6Ii8zMjkzNTYvNDA2Mjk4NDkxLWNlNDYwZTJmLWZlMjUtNDE5My1hZWM4LWNhOTA4MDBiZjliYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNTQwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jMjAxNzE0NGQ4MmNiZDU1ODVkMjI3MjdhNjFlY2I1ZDI2ODRjMDQzZWM0MDQ3Y2YyZGIzNmE4NjAwYWQ0N2RjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.IVLCrrZMuEKXfbFKDXMW0CCElVyU-FA12nZYCZ-FZ7A)
![line-height after dark](https://private-user-images.githubusercontent.com/329356/406298506-d13d9f83-30c0-49ab-bf43-f4426ada8820.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjU1NTMsIm5iZiI6MTczOTQyNTI1MywicGF0aCI6Ii8zMjkzNTYvNDA2Mjk4NTA2LWQxM2Q5ZjgzLTMwYzAtNDlhYi1iZjQzLWY0NDI2YWRhODgyMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNTQwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYTJkMmMxOWJhNWQ1NWQ4NDQ5NTlhZjBkYWNiNWQzMDA5ZWI3NDM5YjlmZTliMmUxNTljOWRlOWVhZWJjNDM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.BtwgMe8rsBfEhqBC7JRAPIqSsZAgXUfHNuH3uKgnoIU)
Proposed Changes
Testing Instructions
trunk
.fix-course-outline-lesson-status-position
.New/Updated Hooks
Deprecated Code
Pre-Merge Checklist