Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class-sensei-learner.php #6423

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

jmalko
Copy link
Contributor

@jmalko jmalko commented Jan 24, 2023

Check for whether post__in turns out to be a string, convert to array, just before final query

Fixes #

Changes proposed in this Pull Request

Simply convert a single ID string to an array, as required by WP_Query

This fixes the errors I've seen site-wide, such as when viewing certificates.

Check for whether post__in turns out to be a string, convert to array, just before final query
@donnapep
Copy link
Collaborator

If you're still able, would you mind sharing how to reproduce this issue? I can't find any instances within the Sensei codebase where we pass post__in as a string to get_enrolled_courses_query, but it's possible I've missed it.

It could also be that some custom code is using a Sensei hook to pass data in the incorrect format. In such a scenario, it would be best to fix the root cause in the custom code rather than addressing the problem directly in Sensei.

@donnapep donnapep added the [Status] Needs Author Reply Requires response from the author label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Author Reply Requires response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants