Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacuum on all releases #2301

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Vacuum on all releases #2301

merged 2 commits into from
Oct 18, 2024

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: #2289 |
|:---:|

Fixes #2289

This PR changes the startup of the app and run a DB vacuum every time there is a new version.

To test

  • Start the app
  • Check if all starts correctly
  • If the database you are running has more than 100 podcasts you should see a loader view
  • After the app started move around
  • Restart the app
  • Check that on the second time the vacuum time is not started.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the crash Crash related issues label Oct 18, 2024
@SergioEstevao SergioEstevao added this to the 7.75 ❄️ milestone Oct 18, 2024
@SergioEstevao SergioEstevao requested a review from a team as a code owner October 18, 2024 12:50
@SergioEstevao SergioEstevao changed the base branch from trunk to release/7.75 October 18, 2024 12:51
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 18, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.75 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any problem!

@SergioEstevao SergioEstevao merged commit 746d9fa into release/7.75 Oct 18, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the vaccuum_on_all_releases branch October 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Crash related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vacuum db for new version
3 participants