Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcripts: enable #2102

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Transcripts: enable #2102

merged 2 commits into from
Aug 28, 2024

Conversation

leandroalonso
Copy link
Member

πŸ“˜ Part of: #1848

Enable transcripts.

To test

  1. Run the app
  2. Open the player
  3. βœ… Transcript button should be there

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added this to the 7.72 milestone Aug 28, 2024
@leandroalonso leandroalonso requested a review from a team as a code owner August 28, 2024 11:05
@leandroalonso leandroalonso requested review from danielebogo and removed request for a team August 28, 2024 11:05
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leandroalonso leandroalonso merged commit 840b695 into trunk Aug 28, 2024
4 of 6 checks passed
@leandroalonso leandroalonso deleted the transcripts/enable branch August 28, 2024 14:14
@BKrnk1337
Copy link

I have a question. I have a podcast that have transcripts.

https://pca.st/episode/774bbde4-05ea-449f-92a3-0db9a5d1740e

But I can see them in PocketCast. If you take a look at the Shownotes the podcast author provides the transcripts in two different file formats:

image

Where can I find the transcripts when running the episode?

@danielebogo
Copy link
Contributor

@BKrnk1337 do you have access to the latest TestFlight? if so you should be able to see the icon in the Shelf

@BKrnk1337
Copy link

@BKrnk1337 do you have access to the latest TestFlight? if so you should be able to see the icon in the Shelf

Jep. Running 7.72.0.0 - freshly installed 45 minutes ago.

@danielebogo
Copy link
Contributor

@BKrnk1337 let me try that podcast on the same version

@SergioEstevao
Copy link
Contributor

@BKrnk1337 do you see the transcript button inside the player?

@BKrnk1337
Copy link

@BKrnk1337 do you see the transcript button inside the player?

No. Even not in the "more action" section

@danielebogo
Copy link
Contributor

@SergioEstevao I can't see it. Could the FF be replaced by the remote config?

@SergioEstevao
Copy link
Contributor

@BKrnk1337 we found the issue, we are going to activate it correctly on our remote config, you should see it soon!

@BKrnk1337
Copy link

@BKrnk1337 we found the issue, we are going to activate it correctly on our remote config, you should see it soon!

Can you give me a ping when I should try?

@SergioEstevao
Copy link
Contributor

@BKrnk1337 Can you try now? It should be set for everyone at this moment.

@BKrnk1337
Copy link

@BKrnk1337 Can you try now? It should be set for everyone at this moment.

Unfortunately not. I even select another episode from the same podcast. And retried the download. There is no button appearing.

@danielebogo
Copy link
Contributor

@BKrnk1337 can you try to close the app and restart?

@BKrnk1337
Copy link

BKrnk1337 commented Sep 3, 2024

@BKrnk1337 can you try to close the app and restart?

I did it. Now I see the button (even in a podcast without transcripts)

But in the podcast I can see the transcripts. Should the transcripts be up to date with the at the moment audio? If yes - it is not.

Unfortunately the button now is stealing a place from the toolbar. Can you add the option to have six icons down there?

@SergioEstevao
Copy link
Contributor

Unfortunately the button now is stealing a place from the toolbar. Can you add the option to have six icons down there?

This was a design option, you can still customise it and remove it from the toolbar.
At the moment we are not planning to allow an extra button on the toolbar, but we will act depending on the feedback we receive so we will keep that in mind.

@danielebogo
Copy link
Contributor

danielebogo commented Sep 3, 2024

Should the transcripts be up to date with the at the moment audio

@BKrnk1337 we don't provide audio/text sync for transcripts yet

@BKrnk1337
Copy link

Thank you for the quick help and clarification. A last question: can I adjust the textsize just for the transcripts?

Great work pocketcast team :)

@danielebogo
Copy link
Contributor

@BKrnk1337 no problem!

can I adjust the textsize just for the transcripts?

Unfortunately no (@SergioEstevao correct me if I'm wrong). But it's a good feedback!!

@SergioEstevao
Copy link
Contributor

can I adjust the textsize just for the transcripts?

You cannot adjust directly on the app, but the transcripts view will adapt it's font size depending on the device font size you set on Settings -> Display & Brightness -> Text Size

@BKrnk1337
Copy link

can I adjust the textsize just for the transcripts?

You cannot adjust directly on the app, but the transcripts view will adapt it's font size depending on the device font size you set on Settings -> Display & Brightness -> Text Size

Ok. Would be a feature request from me. :)

@pachlava pachlava added the [Type] Feature For improving an existing feature or adding a new feature. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Transcripts [Type] Feature For improving an existing feature or adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants