Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty Two Compatibility #21449

Closed
6 tasks done
jeherve opened this issue Oct 18, 2021 · 4 comments
Closed
6 tasks done

Twenty Twenty Two Compatibility #21449

jeherve opened this issue Oct 18, 2021 · 4 comments
Assignees
Labels
Epic Formerly "Primary Issue", or "Master Issue" [Feature] Theme Tools [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Oct 18, 2021

Twenty Twenty Two is expected to ship with WordPress 5.9 at the end of the year. It is currently being developed here:
https://github.com/WordPress/twentytwentytwo

In the past, and with previous default themes, we've added a number of compatibility files and functions to make sure new WordPress site owners had the best experience they could get when using the default theme and Jetpack. In practice, it meant adding the following:

  • Add Infinite Scroll support and tweak CSS to make sure the IS buttons look good.
  • Tweak CSS for Sharing buttons / Likes / Related Posts
  • Alter Gallery widget default width.
  • Style all Jetpack widgets to match the style of the theme.
  • Add Content Options support
  • Ensure that sharing buttons and Likes are not hooked into the excerpt when one is added to a post.

**It's worth noting that Twenty Twenty Two will be a FSE theme, so we may not want to implement all those things this time around.

Previous art on this

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Theme Tools Epic Formerly "Primary Issue", or "Master Issue" labels Oct 18, 2021
@jeherve
Copy link
Member Author

jeherve commented Nov 17, 2021

Tweak CSS for Sharing buttons / Likes / Related Posts

  • Related Posts can be added to any template via a block.
  • Sharing buttons and Likes appear to be displayed properly, I don't think any adjustment is necessary.

@jeherve
Copy link
Member Author

jeherve commented Nov 17, 2021

Alter Gallery widget default width.
Style all Jetpack widgets to match the style of the theme.

Since it's an FSE theme, I do not think we need to worry too much about widgets, since there is no widget area.

@jeherve
Copy link
Member Author

jeherve commented Nov 17, 2021

Add Content Options support

Since it's an FSE theme, there is no customizer and content can be customized in templates. We do not need to worry about this here.

@jeherve jeherve self-assigned this Nov 17, 2021
@jeherve
Copy link
Member Author

jeherve commented Nov 17, 2021

Add Infinite Scroll support

I do not think this will be an option here, since block themes do not use PHP templates that I could call to render a single post or a loop of posts from Infinite Scroll.

Infinite Scroll will need to be adapted to work with FSE themes. Tracking this in #21787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Formerly "Primary Issue", or "Master Issue" [Feature] Theme Tools [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

1 participant