Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Repeat Visitor block - increase notice text size #13645

Closed
joanrho opened this issue Oct 3, 2019 · 0 comments · Fixed by #13640
Closed

Jetpack Repeat Visitor block - increase notice text size #13645

joanrho opened this issue Oct 3, 2019 · 0 comments · Fixed by #13640
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
7.9

Comments

@joanrho
Copy link
Contributor

joanrho commented Oct 3, 2019

Breaking this one out of @simison's original mega-issue #13618 that lists out several visual regressions so we can tackle them one by one in separate PRs.

The text size in the blue notice bar for the Repeat Visitor block is too small at 0.8em. We should bump it up to 1em so it's more legible.

Before/After:

Screen Shot 2019-10-03 at 3 51 18 PM
@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 3, 2019
@joanrho joanrho added this to the 7.9 milestone Oct 3, 2019
@MichaelArestad MichaelArestad mentioned this issue Oct 3, 2019
Merged
@simison simison mentioned this issue Oct 4, 2019
Closed
5 tasks
@jeherve jeherve removed the [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging a pull request may close this issue.

Repeat visitor block - add example Automattic/jetpack
2 participants
@joanrho @jeherve