Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Payments / Pay with PayPal : Duplicated payment blocks affect original block on save #12801

Open
mikeicode opened this issue Jun 20, 2019 · 57 comments
Assignees
Labels
[Block] Pay With Paypal aka Simple Payments Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Earn Earn features [Feature] Pay with PayPal aka Simple Payments [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mikeicode
Copy link

When duplicating a Simple Payments block on a page, editing the duplicated block changes the data of the first block when you make changes and save.

Steps to reproduce

  1. On a test site (tested on Simple and AT) add a Simple Payments block, add content
  2. Duplicate the Block, change information in the block (title, price, etc)
  3. Save changes to the page and refresh the page (in editor or front end)

What I expected

Both blocks should have different content.

What happened instead

The original block updates with the changes you made to the second product block.

Browser / OS version

Don't think this is browser related.

Screenshots

before
after

Video: https://cld.wthms.co/I5GBRA

Context / Source

Noticed this when debugging an issue on a site where a customer duplicated pages which had Simple Payment blocks to quickly create additional product pages.

13544091-hc

@simison simison transferred this issue from Automattic/wp-calypso Jun 20, 2019
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jun 20, 2019
@simison simison added [Type] Bug When a feature is broken and / or not performing as intended Simple Payments labels Jun 20, 2019
@stale
Copy link

stale bot commented Dec 18, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Dec 18, 2019
@khristiansnyder
Copy link

Same issue in 17722296-hc

I can reproduce on my test site as well, in the block editor in both Chrome and Firefox.

On a page with an existing Simple Payments block, adding a new Simple Payments block, and then adding a PayPal email address results in the existing Simple Payments block being duplicated with the same Simple Payments ID.

The workaround is to create a new block in the Classic Editor to have multiple unique payment options on a single page.

@stale stale bot removed the [Status] Stale label Jan 6, 2020
@donalirl
Copy link

Another case of this in #2682316-zen

@sophiegyo
Copy link

sophiegyo commented Mar 16, 2020

Another case: 2790214-zen

On the front end, the duplicate block has the same ID:
simplepaymentsIDs

@sophiegyo
Copy link

Another report in 2799943-zen

@GeoJunkie
Copy link

Ran into this during a Quick Start Session ( 2814595-zen ). The block was added separately and not duplicated, but they both ended up with the same ID:

Editor:
Screen Shot on 2020-03-25 at 10-30-34

Front end:
Screen Shot 2020-03-25 at 10 31 56

Interestingly, when I went back into the editor, the duplication was there, as well:

Screen Shot on 2020-03-25 at 10-33-56

@jeherve
Copy link
Member

jeherve commented Mar 26, 2020

Related: #11406

@sophiegyo
Copy link

Another report: 19711732-hc

simplepaymentsdupebug

@GeoJunkie
Copy link

While applying the workaround from @khristiansnyder , I found that the new Simple Payments Blocks I was adding now have different IDs, so this may be fixed with Gutenberg 7.7.1 (although that introduced a new issue #15121

@GeoJunkie
Copy link

Update after hearing back in 2814595-zen:

The issue with brand new blocks being created with duplicate IDs has been fixed, but the duplicate IDs with duplicated blocks is still occuring:

It would appear that if you try and duplicate the block it will effectively overwrite the content from the block you duplicated. When you add the blocks separately there was no issue.

@dromero20
Copy link

I had another report today in #20224778-hc

@davewhitley
Copy link
Contributor

I would bump this up in priority. It's pretty easy to run into this if you are adding multiple payment blocks on a page. Both my friend and I ran into this exact issue separately while working on a site.

I'll also add that it creates more additional weirdness in the images. In the editor, the blocks all use different images, but on the front end, they are all the same

Screen Shot 2020-05-13 at 2 00 57 PM

@villanovachile
Copy link
Contributor

Had #2978526-zen today with the same issue. Duplicated Simple Payments blocks are duplicating the Payment ID instead of generating a new ID. This results in changes being overwritten to the corresponding blocks.

Video reproducing issue below:

https://d.pr/free/v/VZb10D

@gwensmithx
Copy link

Had this issue today but customer was using the "Copy Page" function. Changes would occur on both pages when made only on the Simple Payments blocks. I noticed the Simple Payment IDs were the same on both pages so this is the same issue but on different pages.

To reproduce - create a new page and add a Simple Payments block. Add info. Save the page and go back out to the Pages list and use the Copy Page function. On the copied page, change some details in the Simple Payments block like the description or price. You'll notice it changes on both the original page and copied page.

#3142927-zen
#16959487-hc

@ktyfuller604
Copy link

Another case #18724623-hc

@isocialtish
Copy link

I came across the same issue in #1595584-hc which resulted in duplicate images

@spncr
Copy link

spncr commented Aug 18, 2020

Chatted with another user today who didn't understand why this was happening #23447827-hc

When duplicating blocks, creating a completely separate instance of that block seems to be much preferred to having two identical blocks that always match.

@mikeicode
Copy link
Author

Another 23672049-hc

@mikeicode
Copy link
Author

Another 23805372-hc

@happychait
Copy link

Another report in 16725720-hc

@BogdanUngureanu
Copy link
Contributor

There's an open PR by @\stacimc in Gutenberg core that proposes an API that would prevent the possibility to copy attributes on duplicate block.

@thekingsprojects
Copy link

Another case here: 13402124-hc

User noticed that their duplicated blocks were showing the correct dates (product titles) on the live page, but the editor was still showing the copied dates, and was receiving notifications that customers had purchased the copied date (e.g., being notified that someone purchased for "9th June" even though the live page showed a date in May or July). All the copied blocks also shared a product ID.

@ClassicRKR27
Copy link

  • 33663475-hc

User had copied the page - removing the block and replacing it on one of them resolved the issue.

@mahfuzurwp
Copy link

Another ticket: 7680582-zen. I could replicate the issue

Copy link
Contributor

github-actions bot commented Feb 11, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 2682316-zen
  • 2790214-zen
  • 2799943-zen
  • 2814595-zen
  • 2978526-zen
  • 3142927-zen
  • 3652531-zen
  • 3667452-zen
  • 3813286-zen
  • 3917877-zen
  • 4134071-zen
  • 4195559-zen
  • 4271338-zen
  • 4413440-zen
  • 4564516-zen
  • 4859419-zen
  • 7680582-zen
  • 7764319-zen
  • 7937957-zen
  • 5553761-zen

@Aurorum
Copy link
Contributor

Aurorum commented Feb 21, 2024

7764319-zen - seemed to really damage user's flow as they have a lot of products

@github-actions github-actions bot added the [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. label Feb 21, 2024
@mariammcWP
Copy link

7937957-zen

@jeherve jeherve marked this as a duplicate of #18689 Jan 22, 2025
@jeherve
Copy link
Member

jeherve commented Jan 22, 2025

Also in #18689.

Internal references:

  • p1612330386044400-slack-CS0SC36SX

@jeherve jeherve marked this as a duplicate of #25009 Jan 22, 2025
@jeherve
Copy link
Member

jeherve commented Jan 22, 2025

Also in #25009.

Internal references:

  • 39100720-hc
  • 36056656-hc
  • 5553761-zd-a8c
  • 28628202-hc

@jeherve jeherve added Earn Earn features [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 22, 2025
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 22, 2025
@jeherve jeherve added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack and removed [Status] In Progress labels Jan 22, 2025
@jeherve jeherve marked this as a duplicate of #12420 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pay With Paypal aka Simple Payments Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" Earn Earn features [Feature] Pay with PayPal aka Simple Payments [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

Successfully merging a pull request may close this issue.