-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Payments / Pay with PayPal : Duplicated payment blocks affect original block on save #12801
Comments
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
Same issue in 17722296-hc I can reproduce on my test site as well, in the block editor in both Chrome and Firefox. On a page with an existing Simple Payments block, adding a new Simple Payments block, and then adding a PayPal email address results in the existing Simple Payments block being duplicated with the same Simple Payments ID. The workaround is to create a new block in the Classic Editor to have multiple unique payment options on a single page. |
Another case of this in #2682316-zen |
Another report in 2799943-zen |
Related: #11406 |
While applying the workaround from @khristiansnyder , I found that the new Simple Payments Blocks I was adding now have different IDs, so this may be fixed with Gutenberg 7.7.1 (although that introduced a new issue #15121 |
Update after hearing back in 2814595-zen: The issue with brand new blocks being created with duplicate IDs has been fixed, but the duplicate IDs with duplicated blocks is still occuring:
|
I had another report today in #20224778-hc |
I would bump this up in priority. It's pretty easy to run into this if you are adding multiple payment blocks on a page. Both my friend and I ran into this exact issue separately while working on a site. I'll also add that it creates more additional weirdness in the images. In the editor, the blocks all use different images, but on the front end, they are all the same |
Had #2978526-zen today with the same issue. Duplicated Simple Payments blocks are duplicating the Payment ID instead of generating a new ID. This results in changes being overwritten to the corresponding blocks. Video reproducing issue below: |
Had this issue today but customer was using the "Copy Page" function. Changes would occur on both pages when made only on the Simple Payments blocks. I noticed the Simple Payment IDs were the same on both pages so this is the same issue but on different pages. To reproduce - create a new page and add a Simple Payments block. Add info. Save the page and go back out to the Pages list and use the Copy Page function. On the copied page, change some details in the Simple Payments block like the description or price. You'll notice it changes on both the original page and copied page. #3142927-zen |
Another case #18724623-hc |
I came across the same issue in #1595584-hc which resulted in duplicate images |
Chatted with another user today who didn't understand why this was happening #23447827-hc When duplicating blocks, creating a completely separate instance of that block seems to be much preferred to having two identical blocks that always match. |
Another 23672049-hc |
Another 23805372-hc |
Another report in 16725720-hc |
There's an open PR by @\stacimc in Gutenberg core that proposes an API that would prevent the possibility to copy attributes on duplicate block. |
Another case here: 13402124-hc User noticed that their duplicated blocks were showing the correct dates (product titles) on the live page, but the editor was still showing the copied dates, and was receiving notifications that customers had purchased the copied date (e.g., being notified that someone purchased for "9th June" even though the live page showed a date in May or July). All the copied blocks also shared a product ID. |
User had copied the page - removing the block and replacing it on one of them resolved the issue. |
Another ticket: 7680582-zen. I could replicate the issue |
Support References This comment is automatically generated. Please do not edit it.
|
7764319-zen - seemed to really damage user's flow as they have a lot of products |
7937957-zen |
Also in #18689. Internal references:
|
Also in #25009. Internal references:
|
When duplicating a Simple Payments block on a page, editing the duplicated block changes the data of the first block when you make changes and save.
Steps to reproduce
What I expected
Both blocks should have different content.
What happened instead
The original block updates with the changes you made to the second product block.
Browser / OS version
Don't think this is browser related.
Screenshots
Video: https://cld.wthms.co/I5GBRA
Context / Source
Noticed this when debugging an issue on a site where a customer duplicated pages which had Simple Payment blocks to quickly create additional product pages.
13544091-hc
The text was updated successfully, but these errors were encountered: