Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jshint #11914

Closed
simison opened this issue Apr 4, 2019 · 0 comments · Fixed by #11915
Closed

Remove jshint #11914

simison opened this issue Apr 4, 2019 · 0 comments · Fixed by #11915
Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial

Comments

@simison
Copy link
Member

simison commented Apr 4, 2019

We now have jshint and eslint to take care of code style standards. We should replace jshint with eslint.

If the current set of Jshint rules is inherited from core, there's a migration ruleset in @wordpress/eslint-plugin that we can use directly.

I see some differences between Jetpack and WordPress jshint files — could be that Jetpack one is just out of date?

There are some jshint inline rules that had been removed from JShint long time ago already:

/* jshint devel: true, onevar: false, smarttabs: true */

PR in Gutenberg for reference WordPress/gutenberg#12840

cc @brbrr

@simison simison added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants