Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Read stackoverflow #1037

Closed
superhx opened this issue Mar 28, 2024 · 1 comment · Fixed by #1038
Closed

[BUG] Read stackoverflow #1037

superhx opened this issue Mar 28, 2024 · 1 comment · Fixed by #1038
Assignees
Labels
bug Something isn't working

Comments

@superhx
Copy link
Collaborator

superhx commented Mar 28, 2024

image

@Chillax-0v0
Copy link
Contributor

Caused by #1011

Details:
Let 2 parts of stream 1 in LogCache: [0, 10], [100, 200]

  • Call LogCache#get with (streamId=1, start=5, end=20, max=100) will return an empty list, as records [10, 20] not in LogCache.
  • However, Call LogCache#getFirstRecordBaseOffset with (streamId=1, start=5, end=20, and max=1 set by getFirstRecordBaseOffset) will return the record at offset=5.
    This will cause mismatches between get and getFirst and lead to infinite recursion.

Revert #1011 in #1038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants