Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terminal-integration): add toggleterm-manager.nvim #959

Merged
merged 2 commits into from
May 14, 2024

Conversation

LumenYoung
Copy link
Contributor

@LumenYoung LumenYoung commented May 13, 2024

📑 Description

Create a config for the toggleterm manager plugin, which uses telescope to give you clear overview on the toggleterm buffers you opened.

ℹ Additional Information

I've added addtional keymaps in the telescope interface to make it easy to use. Also I mapped <Leader>ts to this plugin.

Copy link

github-actions bot commented May 13, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@mehalter mehalter force-pushed the main branch 2 times, most recently from 881e08d to 36de23d Compare May 14, 2024 20:17
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished up this PR:

  1. applied comments
  2. fixed name utility/toggleterm-manager should be terminal-integration/toggleterm-manager-nvim
  3. Integrated with AstroUI icon configuration which also gets support for disabling icons
  4. Remove duplicate mappings set in default setup

@mehalter mehalter changed the title feat(utility): add toggleterm-manager feat(terminal-integration): add toggleterm-manager.nvim May 14, 2024
@mehalter mehalter merged commit 22a9151 into AstroNvim:main May 14, 2024
12 checks passed
@LumenYoung
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants