Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rainbow-delimiters-nvim): fix setup function due to breaking change #610

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

valentino-sm
Copy link
Contributor

@valentino-sm valentino-sm commented Oct 15, 2023

📑 Description

ℹ Additional Information

Breaking change in f1ce55edcbd2c25a544c93357c66d4172a870766

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@valentino-sm valentino-sm changed the title fix(rainbow-delimiters): setup function fix(rainbow-delimiters): fix setup function Oct 15, 2023
@valentino-sm valentino-sm changed the title fix(rainbow-delimiters): fix setup function fix(rainbow-delimiters-nvim): fix setup function Oct 15, 2023
@Uzaaft Uzaaft changed the title fix(rainbow-delimiters-nvim): fix setup function fix(rainbow-delimiters-nvim): fix setup function due to https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766 Oct 16, 2023
@Uzaaft Uzaaft changed the title fix(rainbow-delimiters-nvim): fix setup function due to https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766 fix(rainbow-delimiters-nvim): fix setup function due to [breaking change](https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766) Oct 16, 2023
@Uzaaft Uzaaft changed the title fix(rainbow-delimiters-nvim): fix setup function due to [breaking change](https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766) fix(rainbow-delimiters-nvim): fix setup function due to (breaking change)[https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766] Oct 16, 2023
@Uzaaft Uzaaft changed the title fix(rainbow-delimiters-nvim): fix setup function due to (breaking change)[https://github.com/HiPhish/rainbow-delimiters.nvim/commit/f1ce55edcbd2c25a544c93357c66d4172a870766] fix(rainbow-delimiters-nvim): fix setup function due to breaking change Oct 16, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the config function all together and just set up the main module name

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit 5c3ce63 into AstroNvim:main Oct 16, 2023
@valentino-sm valentino-sm deleted the patch-1 branch October 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants