Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): Add swift pack #606

Merged
merged 7 commits into from
Nov 2, 2023
Merged

feat(pack): Add swift pack #606

merged 7 commits into from
Nov 2, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Oct 14, 2023

This PR adds a WIP Swift pack

@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 14, 2023

{
 "AstroNvim/astrocommunity",
branch = "dev_swift",
...
}```

@luxus
Copy link
Member

luxus commented Oct 24, 2023

swift? oh wow :D

@Uzaaft
Copy link
Member Author

Uzaaft commented Oct 25, 2023

swift? oh wow :D

Gotta get them all.
The experience wasnt perfect, so we might just release it as is with beta status

@Uzaaft Uzaaft marked this pull request as ready for review October 30, 2023 04:45
@Uzaaft Uzaaft requested a review from a team October 30, 2023 15:20
Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luxus luxus merged commit 0ac1d37 into main Nov 2, 2023
@luxus luxus deleted the dev_swift branch November 2, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants