Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vim-matchup): remove matchup_match_paren_deferred option #561

Merged

Conversation

kaka-ruto
Copy link
Contributor

@kaka-ruto kaka-ruto commented Sep 8, 2023

This will leave the option set to 0 by default

📑 Description

ℹ Additional Information

See demo video of the issue on AstroNvim/AstroNvim#2276

This will leave the option set to 0 by default

It was causing issues, by printing matching content on top of buffers in split screens

Relevant issue: AstroNvim/AstroNvim#2276
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@kaka-ruto kaka-ruto changed the title Remove vim.matchup_match_paren_deferred option fix(vim-matchup): remove vim.matchup_match_paren_deferred option Sep 8, 2023
@kaka-ruto kaka-ruto changed the title fix(vim-matchup): remove vim.matchup_match_paren_deferred option fix(vim-matchup): remove matchup_match_paren_deferred option Sep 8, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 751812a into AstroNvim:main Sep 8, 2023
@kaka-ruto kaka-ruto deleted the fix-vim-matchup-screen-popup-issue branch September 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants