Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvim-spectre): Make which-key entry color blue #413

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

bruunoromero
Copy link
Contributor

I believe the Spectre entry in which-key should be blue because it is a nested keymap, unfortunately when using keys it doesn't get highlighted properly, this pr fixes it.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@bruunoromero bruunoromero changed the title fix(spectre): Make which-key entry color blue and add icon fix(spectre): Make which-key entry color blue Jul 12, 2023
Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owittek
Copy link
Member

owittek commented Jul 12, 2023

Oh, you'll have to change the scope from spectre to nvim-spectre before I can merge the changes

@owittek owittek changed the title fix(spectre): Make which-key entry color blue fix(nvim-spectre): Make which-key entry color blue Jul 12, 2023
@owittek owittek merged commit f72c5cc into AstroNvim:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants