Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(programming-language-support): Add support for rest-nvim #384

Merged
merged 6 commits into from
Jul 9, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 9, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 9, 2023

@owittek Added your suggestions :)

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like styling needs some fixing

@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 9, 2023

Yeah I was wondering about it myself, but stylua didn't reformat it at my end :|

@mehalter
Copy link
Member

mehalter commented Jul 9, 2023

Ok 😂 someone has to fix it lmfao. Looking at the logs it's just that you shouldn't have parentheses for the require

@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 9, 2023

Ok 😂 someone has to fix it lmfao. Looking at the logs it's just that you shouldn't have parentheses for the require

Oh, I thought the table paranthesis also looked weird but 🤷🏾‍♂️

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 74393f5 into main Jul 9, 2023
@mehalter mehalter deleted the rest-nvim branch July 9, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants