Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add full-dadbod plugin pack #368

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

KenroLe
Copy link
Contributor

@KenroLe KenroLe commented Jul 5, 2023

I dont know what the namespacing guidelines are so I applied intuition there.
This configuration works on my machine, thanks mehalter for lazyloading cmp and making the autocmd less funky.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@KenroLe KenroLe changed the title feat(dadbod) added vim-dadbod feat(dadbod): added vim-dadbod Jul 5, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go under programming-languages-support rather than sql. This is a category in NeovimCraft that seems the most applicable and also a bit more generally accepting than an sql category. Also could you please add an appropriate README file to that as well :)

Note: Also just to note, I updated the pull request title to match what it should be. It won't pass the semantic PR check until the folder is fixed

@mehalter mehalter changed the title feat(dadbod): added vim-dadbod feat(programming-languages-support): added vim-dadbod Jul 5, 2023
@mehalter mehalter changed the title feat(programming-languages-support): added vim-dadbod feat(programming-languages-support): add vim-dadbod Jul 5, 2023
@mehalter mehalter changed the title feat(programming-languages-support): add vim-dadbod feat(programming-languages-support): add vim-dadbod (test, will remove) Jul 5, 2023
@mehalter mehalter changed the title feat(programming-languages-support): add vim-dadbod (test, will remove) feat(programming-languages-support): add vim-dadbod Jul 5, 2023
@mehalter
Copy link
Member

mehalter commented Jul 5, 2023

@KenroLe I went ahead and added the README and further fixed the folder names :)

@Uzaaft do you think this should be a pack since it provides 2 plugins?

@KenroLe
Copy link
Contributor Author

KenroLe commented Jul 5, 2023

@KenroLe I went ahead and added the README and further fixed the folder names :)

@Uzaaft do you think this should be a pack since it provides 2 plugins?

Tyvm, ill get it right next time 👍

@mehalter mehalter changed the title feat(programming-languages-support): add vim-dadbod feat(pack): add vim-dadbod plugin pack Jul 5, 2023
@mehalter mehalter requested a review from a team July 6, 2023 01:05
@Uzaaft
Copy link
Member

Uzaaft commented Jul 6, 2023

@KenroLe I went ahead and added the README and further fixed the folder names :)
@Uzaaft do you think this should be a pack since it provides 2 plugins?

Tyvm, ill get it right next time 👍

I think it should be a pack since it uses multiple plugins to provide a way to interface with DB’s

@mehalter
Copy link
Member

mehalter commented Jul 6, 2023

What do you think of how I have it set up currently @Uzaaft ? Good to merge? :) It's ready for review

@mehalter mehalter changed the title feat(pack): add vim-dadbod plugin pack feat(pack): add full-dadbod plugin pack Jul 6, 2023
@mehalter
Copy link
Member

mehalter commented Jul 6, 2023

No one has complained, so I'm just going to ship this! Thanks @KenroLe for the contribution!

@mehalter mehalter merged commit c603039 into AstroNvim:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants