-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): add full-dadbod plugin pack #368
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go under programming-languages-support
rather than sql
. This is a category in NeovimCraft that seems the most applicable and also a bit more generally accepting than an sql
category. Also could you please add an appropriate README
file to that as well :)
Note: Also just to note, I updated the pull request title to match what it should be. It won't pass the semantic PR check until the folder is fixed
What do you think of how I have it set up currently @Uzaaft ? Good to merge? :) It's ready for review |
No one has complained, so I'm just going to ship this! Thanks @KenroLe for the contribution! |
I dont know what the namespacing guidelines are so I applied intuition there.
This configuration works on my machine, thanks mehalter for lazyloading cmp and making the autocmd less funky.