Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(colorscheme): add 'vscode', 'onedarkpro', 'sonokai' #242

Merged
merged 5 commits into from
May 28, 2023
Merged

feat(colorscheme): add 'vscode', 'onedarkpro', 'sonokai' #242

merged 5 commits into from
May 28, 2023

Conversation

TheSast
Copy link
Contributor

@TheSast TheSast commented May 28, 2023

No description provided.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be colorscheme/ondedarkpro-nvim as the folder name and colorscheme/vscode-nvim as the folder name. After those changes this looks great!

@TheSast
Copy link
Contributor Author

TheSast commented May 28, 2023

I saw some other colorscheme modules omitting the suffix so I did't add it (e.g. dracula.nvim, gruvbox.nvim, kanagawa.nvim, tokyonight.nvim, etc.).
If you reconfirm (a github emoji reaction would be enough) that you want to include the suffix I'll push the rename.

@mehalter
Copy link
Member

These should be fixed and are bugs that slipped through the cracks. These can be fixed without breaking changes as they are bugs. Could you also please open a PR that resolves this?

@mehalter
Copy link
Member

These are described in the contribution guidelines so it seems like some people aren't enforcing them @AstroNvim/astrocommunity-maintainers and some people are not reading them :/ Thanks for bringing this to my attention though! Luckily we can resolve this without breaking change even though it will be "breaking" to users since they are currently incorrect and against our methodology

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you could make a PR to fix the other inconsistencies with the suffixes that would be greatly appreciated! If not, I can make one in the next few days

@mehalter mehalter merged commit a717c95 into AstroNvim:main May 28, 2023
@TheSast
Copy link
Contributor Author

TheSast commented May 28, 2023

ah, I was to slow, a "merged main into X" commit has slipped in there

@mehalter
Copy link
Member

Haha no worries @TheSast it wouldn't make it into our git log because this repo only does squash and merge

Uzaaft pushed a commit that referenced this pull request Jun 11, 2023
* chore: add 'optional' where applicable

* feat(colorscheme): add 'vscode'

* feat(colorscheme): add 'sonokai'

* feat(colorscheme): add 'onedarkpro'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants