-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colorscheme): add 'vscode', 'onedarkpro', 'sonokai' #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be colorscheme/ondedarkpro-nvim
as the folder name and colorscheme/vscode-nvim
as the folder name. After those changes this looks great!
I saw some other colorscheme modules omitting the suffix so I did't add it (e.g. dracula.nvim, gruvbox.nvim, kanagawa.nvim, tokyonight.nvim, etc.). |
These should be fixed and are bugs that slipped through the cracks. These can be fixed without breaking changes as they are bugs. Could you also please open a PR that resolves this? |
These are described in the contribution guidelines so it seems like some people aren't enforcing them @AstroNvim/astrocommunity-maintainers and some people are not reading them :/ Thanks for bringing this to my attention though! Luckily we can resolve this without breaking change even though it will be "breaking" to users since they are currently incorrect and against our methodology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! If you could make a PR to fix the other inconsistencies with the suffixes that would be greatly appreciated! If not, I can make one in the next few days
ah, I was to slow, a "merged main into X" commit has slipped in there |
Haha no worries @TheSast it wouldn't make it into our git log because this repo only does squash and merge |
* chore: add 'optional' where applicable * feat(colorscheme): add 'vscode' * feat(colorscheme): add 'sonokai' * feat(colorscheme): add 'onedarkpro'
No description provided.