feat(pack): enable automatic install of haskell dap

[owittek]

Relies on jay-babu/mason-nvim-dap.nvim#88

[sjcobb2022]

Oh sick nice you opened up a pull. Thanks man!

[sjcobb2022]

@owittek There are some changes that are needed to get haskell-tools to work with the haskell-debug adapter.

My fork has the necessary changes: https://github.com/sjcobb2022/astrocommunity

[owittek]

@owittek There are some changes that are needed to get haskell-tools to work with the haskell-debug adapter.

My fork has the necessary changes: https://github.com/sjcobb2022/astrocommunity

You should be able to PR this to my fork so that it will be added to this PR. I don't know if there's an easier way to get those changes over here.

[sjcobb2022]

@owittek pull is on ur fork.

[mehalter]

@sjcobb2022 why the Change to this line?

https://github.com/sjcobb2022/astrocommunity/blob/main/lua/astrocommunity/pack/haskell/haskell.lua#L23

[sjcobb2022]

@sjcobb2022 why the Change to this line?

https://github.com/sjcobb2022/astrocommunity/blob/main/lua/astrocommunity/pack/haskell/haskell.lua#L23

I can change that back. Just though it looked a bit cleaner. Probably changed it when i was messing around trying to get it to work.

[mehalter]

Oh wait, @sjcobb2022 it looks like you reverted all of the new insert_list_unique syntax 🤔 was that accidental in resolving merge conflicts maybe?

[owittek]

@owittek pull is on ur fork.

I have reviewed your changes. It would be the easiest to rebase your changes on top of the current master & then just add your autocmd.

[mehalter]

@owittek it might be easier for you to manually add the changes into this branch and setting @sjcobb2022 as the commit author

[sjcobb2022]

@owittek it might be easier for you to manually add the changes into this branch and setting @sjcobb2022 as the commit author

Sorry for the hassle, it should be fixed now. I'm really crap at git.

[owittek]

@sjcobb2022 Please take a look if I have committed all your changes.

[sjcobb2022]

@sjcobb2022 Please take a look if I have committed all your changes.

I think the dependency on mason-nvim-dap should be changed.

[mehalter]

Yeah I agree, @owittek mason-nvim-dap shouldn't be in the dependency list. It should just be another item in the top level table

[sjcobb2022]

Everything looks good now! Sorry for the issues. Didn't realize there was an API change.

[owittek]

Yeah I agree, @owittek mason-nvim-dap shouldn't be in the dependency list. It should just be another item in the top level table

Don't worry, I merged the changes quicker than you can type 😜

[mehalter]

Great! Now we play the waiting game :)

Also no worries @sjcobb2022 ! The old syntax does still work completely fine, but we did recently improve the syntax to decrease the amount of boilerplate code needed

[sjcobb2022]

[email protected] has been released!

[owittek]

[email protected] has been released!

I have verified this but I can't merge it without a review since I was the last person to push to this PR.

[mehalter]

LGTM