Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git): Add octo #138

Merged
merged 8 commits into from
Apr 26, 2023
Merged

feat(git): Add octo #138

merged 8 commits into from
Apr 26, 2023

Conversation

0xricksanchez
Copy link
Contributor

First attempt to add octo.nvim. I added some (imo) usable mappings to AstroNvim as well.

@0xricksanchez 0xricksanchez changed the title (feat) Add octo feat: Add octo Apr 13, 2023
@Uzaaft
Copy link
Member

Uzaaft commented Apr 13, 2023

I believe that we shouldn't provide mappings, that's something the end-user should add. Instead, they can be added to the readme and be added by the end-user if they'd want

@0xricksanchez
Copy link
Contributor Author

I believe that we shouldn't provide mappings, that's something the end-user should add. Instead, they can be added to the readme and be added by the end-user if they'd want

Fine by me. I’ll get this changed tomorrow

@luxus
Copy link
Member

luxus commented Apr 14, 2023

isnt the general prefix for git g?
and not sure about the readme and keymap stuff..
in general adding keymaps is fine. there are no rules for that in astrocommunity.

@luxus luxus self-requested a review April 14, 2023 04:56
@0xricksanchez
Copy link
Contributor Author

0xricksanchez commented Apr 14, 2023

isnt the general prefix for git g?

That's what I was playing around with first. However, I found some functions are behind a very long series of keystrokes, so getting rid of at least 1 level already improved things a bit from a UX PoV. That said, I agree it's still far from ideal...

I think octo would be a fine addition to the repo, so if you have preferences on how to shape this PR just lmk :)

@Uzaaft
Copy link
Member

Uzaaft commented Apr 14, 2023

isnt the general prefix for git g? and not sure about the readme and keymap stuff.. in general adding keymaps is fine. there are no rules for that in astrocommunity.

How would <leader>G work?

@luxus
Copy link
Member

luxus commented Apr 16, 2023

not sure about this yet.. does someone else have inputs?

@0xricksanchez
Copy link
Contributor Author

<leader>G sounds better suited to me than the previous <leader>O. Generally, I'd still love to place the octo stuff inside the git functionality but didn't find a way to improve the keybinds properly yet

@luxus
Copy link
Member

luxus commented Apr 22, 2023

@Uzaaft are you now fine with this

@Uzaaft
Copy link
Member

Uzaaft commented Apr 22, 2023

@luxus Would it be possible to add conditional keymappings? I think many of the keymappings that are set here only works for the Octo filetype.

@luxus
Copy link
Member

luxus commented Apr 22, 2023

don't think this exists.. maybe something that loads configs in root folders? but i guess that's out of scope

@Uzaaft
Copy link
Member

Uzaaft commented Apr 23, 2023

Yeah IG. I guess this PR is good enough for an initial version, I'll talk with mehalter about the file spesific things.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure style and linting checks pass.

@mehalter mehalter changed the title feat: Add octo feat(git): Add octo Apr 26, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit f60b33f into AstroNvim:main Apr 26, 2023
@0xricksanchez 0xricksanchez deleted the add_octo branch April 26, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants