-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git): Add octo #138
feat(git): Add octo #138
Conversation
I believe that we shouldn't provide mappings, that's something the end-user should add. Instead, they can be added to the readme and be added by the end-user if they'd want |
Fine by me. I’ll get this changed tomorrow |
isnt the general prefix for git g? |
That's what I was playing around with first. However, I found some functions are behind a very long series of keystrokes, so getting rid of at least 1 level already improved things a bit from a UX PoV. That said, I agree it's still far from ideal... I think |
How would |
not sure about this yet.. does someone else have inputs? |
|
@Uzaaft are you now fine with this |
@luxus Would it be possible to add conditional keymappings? I think many of the keymappings that are set here only works for the Octo filetype. |
don't think this exists.. maybe something that loads configs in root folders? but i guess that's out of scope |
Yeah IG. I guess this PR is good enough for an initial version, I'll talk with mehalter about the file spesific things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure style and linting checks pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First attempt to add
octo.nvim
. I added some (imo) usable mappings to AstroNvim as well.