Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copilotchat-nvim): select a picker based on installed one #1333

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Jan 25, 2025

📑 Description

This removes mandatory dependency on telescope and selects the picker based on which one is installed instead with a default to the telescope.

ℹ Additional Information

Can see different integrations here:
https://github.com/CopilotC-Nvim/CopilotChat.nvim/tree/main/lua/CopilotChat/integrations

Copy link

github-actions bot commented Jan 25, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Jan 25, 2025

Gonna mark this as draft until docs are added just to safeguard our own sanity.

@azdanov
Copy link
Contributor Author

azdanov commented Jan 25, 2025

Also would give time for any bugs to get fixed on their side

@tku137
Copy link
Contributor

tku137 commented Jan 25, 2025

Done here CopilotC-Nvim/CopilotChat.nvim#726

@Uzaaft Uzaaft marked this pull request as ready for review January 25, 2025 18:18
@Uzaaft Uzaaft merged commit 0e1cf11 into AstroNvim:main Jan 25, 2025
16 checks passed
@tku137
Copy link
Contributor

tku137 commented Jan 26, 2025

A follow-up refactor based on this PR: #1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants