Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preffered yaml formatter for docker and yaml packs #1309

Closed
azdanov opened this issue Jan 6, 2025 · 1 comment · Fixed by #1321
Closed

Preffered yaml formatter for docker and yaml packs #1309

azdanov opened this issue Jan 6, 2025 · 1 comment · Fixed by #1321
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@azdanov
Copy link
Contributor

azdanov commented Jan 6, 2025

Is your feature related to a problem?

It would be good to have a default formatter for both the docker and yaml language packs. At the moment if only docker pack is installed then it defaults to docker_compose_language_service for yaml files, but if both packs are installed then either yamlls or prettierd are also used alongside the docker one.

Describe the new feature

It would be good to have a single formatter defined for both the packs, since docker is writte using yaml.

Additional context

I'm not sure which formatter would be the best. I guess prettier since it's so popular.

I can try to create a PR, but would need some guidance 🙂

Should docker pack also include the yaml pack? To avoid repeating configs. Or is it better to have a self contained packs?

@azdanov azdanov added the enhancement New feature or request label Jan 6, 2025
@azdanov
Copy link
Contributor Author

azdanov commented Jan 6, 2025

As a side note, I noticed that codelens actions did not work for docker-compose-language-service for me. E.g. to run docker-compose file or a single container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants