Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conform-nvim): fix bug caused by wrongly typed opt #1125

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Niverton
Copy link
Contributor

This PR fixes conform not falling back to the LSP for formatting introduced by 876032f. The last commit contains a typo, the proper name for the lsp option is lsp_format.
Currently the default config is "never", so formatting does not work if the LSP is the only formatter available.

Copy link

github-actions bot commented Jul 24, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft changed the title fix(conform-nvim): fixed default_format_opts lsp option fix(conform-nvim): fix bug caused by wrongly typed opt Jul 24, 2024
@Uzaaft Uzaaft merged commit 8e1a2a4 into AstroNvim:main Jul 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants