Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codesnap-nvim): support for windows users #1123

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

Std-Enigma
Copy link
Contributor

📑 Description

ℹ Additional Information

This plugin at least on the latest version doesn't support windows by any means but the "0.0.x" version does however but it's not so performant and works kinda differently

This PR make sures that windows users get the latest working version that supports their OS

Copy link

github-actions bot commented Jul 23, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Std-Enigma Std-Enigma changed the title Impr(codesnap-nvim): support for windows users impr(codesnap-nvim): support for windows users Jul 23, 2024
@Std-Enigma Std-Enigma changed the title impr(codesnap-nvim): support for windows users feat(codesnap-nvim): support for windows users Jul 23, 2024
@ALameLlama
Copy link
Member

This looks good to me but i think @Uzaaft was looking into an upstream change

@Std-Enigma
Copy link
Contributor Author

upstream change
so you mean i should I've just pushed this changes to the same pr i made a while ago?

@Uzaaft
Copy link
Member

Uzaaft commented Jul 24, 2024

upstream change
so you mean i should I've just pushed this changes to the same pr i made a while ago?

What?

@Uzaaft
Copy link
Member

Uzaaft commented Jul 24, 2024

This looks good to me but i think @Uzaaft was looking into an upstream change

I’m just going to upstream some changes to add a default location to save images. That shouldn’t affect this :)

@Uzaaft
Copy link
Member

Uzaaft commented Jul 24, 2024

@Std-Enigma can you add a note into the readme to document this behaviour

This commit also adds extra information about windows support and
versioning
@ALameLlama
Copy link
Member

Lgtm

@ALameLlama ALameLlama merged commit d00eed8 into AstroNvim:main Jul 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants