-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trouble-nvim): prevent clashes with existing <Leader>x
mappings
#1105
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
03cab3f
to
b303c45
Compare
We can leave all the mappings as is, just change |
No need to make them all 3 key presses when they can share the Quickfix/Lists menu |
<Leader>xt
<Leader>x
mappings
@mehalter Thanks for your suggestion! I'll modify my PR accordingly. |
@mehalter What if other types of Quickfix/Lists show up later though? Looks like we are prioritizing |
Yeah I think if the user adds several list plugins it can just be up to them the priority they want |
@mehalter Okay, I've applied your suggestions. One problem I have is that the original descriptions are too long, so I've tried my best to shorten them a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the original messages no? That mention Trouble?
@rami3l this should be a 2 character change PR |
This is to avoid clashes with the [recent addition of `<Leader>x` to AstroNvim](AstroNvim/AstroNvim@99c2b13).
Ah I see your most recent comment now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Looks good
@mehalter Thanks a lot, and sorry for the previous confusion! 🙇 |
📑 Description
This is to avoid clashes with the recent addition of
<Leader>x
to AstroNvim.This PR has also simplified some mapping descriptions.