Redo layout of character selection window #2532

Also rework button sounds so that they have consistent sounds throughout the engine

Author: lodicolo

Intersect.Client.Core/Core/Input.cs

@@ -232,10 +232,14 @@ public static void OnKeyPressed(Keys modifier, Keys key)
                     switch (control)
                     {
                         case Control.Enter:
-                            if (!selectCharacterWindow.IsHidden && selectCharacterWindow.Characters[selectCharacterWindow.mSelectedChar] != null)
+                            if (selectCharacterWindow is { IsHidden: false, CharacterSelectionPreviews: { } previews })
                             {
-                                selectCharacterWindow.ButtonPlay_Clicked(null, null);
-                                consumeKey = true;
+                                var selectedPreviewIndex = selectCharacterWindow._selectedCharacterIndex;
+                                if (previews.Length > selectedPreviewIndex && previews[selectedPreviewIndex] != default)
+                                {
+                                    selectCharacterWindow.ButtonPlay_Clicked(null, null);
+                                    consumeKey = true;
+                                }
                             }
                             break;
                     }

Intersect.Client.Core/Interface/Menu/CharacterSelectionPreviewMetadata.cs

@@ -0,0 +1,13 @@
+using Intersect.Network.Packets.Server;
+
+namespace Intersect.Client.Interface.Menu;
+
+public record struct CharacterSelectionPreviewMetadata(
+    Guid Id,
+    string Name,
+    string Sprite,
+    string Face,
+    int Level,
+    string Class,
+    EquipmentFragment[] Equipment
+);

Intersect.Client.Core/Interface/Menu/LoginWindow.cs

@@ -4,6 +4,7 @@
 using Intersect.Client.Framework.Gwen;
 using Intersect.Client.Framework.Gwen.Control;
 using Intersect.Client.Framework.Gwen.Control.EventArguments;
+using Intersect.Client.Framework.Gwen.ControlInternal;
 using Intersect.Client.Framework.Input;
 using Intersect.Client.General;
 using Intersect.Client.Interface.Game.Chat;

Intersect.Client.Core/Interface/Menu/MainMenu.cs

@@ -176,10 +176,10 @@ public void Reset()
 
     public void Hide() => _mainMenuWindow.Hide();
 
-    public void NotifyOpenCharacterSelection(List<Character> characters)
+    public void NotifyOpenCharacterSelection(List<CharacterSelectionPreviewMetadata> characterSelectionPreviews)
     {
         mShouldOpenCharacterSelection = true;
-        SelectCharacterWindow.Characters = [.. characters];
+        SelectCharacterWindow.CharacterSelectionPreviews = [..characterSelectionPreviews];
     }
 
     public void NotifyOpenForgotPassword()