Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - + > then → #4277

Open
PeterHero opened this issue Jan 2, 2024 · 5 comments
Open

[FR] - + > then → #4277

PeterHero opened this issue Jan 2, 2024 · 5 comments
Assignees
Labels
2025 editor features related to the rich-text editor

Comments

@PeterHero
Copy link

PeterHero commented Jan 2, 2024

Description

Enable users to type - + > to insert →

Impact

Shortcut users

Additional Context

Similar to #2309

@LucasXu0 LucasXu0 added editor features related to the rich-text editor 2024 labels Jan 2, 2024
@Xazin Xazin self-assigned this Jan 5, 2024
@Jayaprakash-dev
Copy link
Contributor

Hey @Xazin, can I work on this?

I've already implemented the code for formatting and widget testing.

@Xazin
Copy link
Contributor

Xazin commented Jan 10, 2024

Hey @Xazin, can I work on this?

I've already implemented the code for formatting and widget testing.

Sure you can, this has to be implemented in the Editor, and please reuse the same method that the shortcut for => does.

I cannot remember if I added a test for the =>, if there is add one to the same test file, otherwise can you add test for both cases?

I'll assign you 👍

@Jayaprakash-dev
Copy link
Contributor

Hey @Xazin,

I've opened pull request # 665 in the appflowy-editor repository to address the reported issue.

@annieappflowy
Copy link
Collaborator

I see the PR for this feature was merged. Just tried it but it doesn't work in AppFlowy?

@Xazin
Copy link
Contributor

Xazin commented Jun 22, 2024

I see the PR for this feature was merged. Just tried it but it doesn't work in AppFlowy?

It was not included by default, see this:

AppFlowy-IO/appflowy-editor#665 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025 editor features related to the rich-text editor
Projects
None yet
Development

No branches or pull requests

6 participants