Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: operator disables Ingress when spec.(component).host is empty #5305

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

jsenko
Copy link
Member

@jsenko jsenko commented Oct 4, 2024

No description provided.

@jsenko
Copy link
Member Author

jsenko commented Oct 4, 2024

@andreaTP review please

@jsenko
Copy link
Member Author

jsenko commented Oct 4, 2024

hi @andreaTP I've added two more commits with a fix and a workaround for remote tests. As I mentioned in our discussion, the remote tests do not work properly:

  • Remote tests deploy two operators at once, one local and one remote. This makes tests unstable.
  • I found out that the remote operator was actually failing to deploy at all, because the generated resources did not properly generate ClusterRoleBinding.

I can either bring up my suggested changes to the testsuite in a separate PR, or I can create an issue for you to fix the remote tests.

andreaTP
andreaTP previously approved these changes Oct 4, 2024
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping the scope limited to the change, appreciated!

Is the bug in the testing blocking you?
I would check what we are doing differently from KC.

No strong preference, I can look into the bug later on next week or review a separate PR with the fix, as you prefer 👍

@jsenko
Copy link
Member Author

jsenko commented Oct 4, 2024

LGTM, thanks for keeping the scope limited to the change, appreciated!

Is the bug in the testing blocking you? I would check what we are doing differently from KC.

No strong preference, I can look into the bug later on next week or review a separate PR with the fix, as you prefer 👍

It's not blocking, but it'll make tests harder to write. I'll recreate a PR with my changes and we can discuss them. I'll also take a look at KC, but I think we should not try too strongly to reproduce everything they do, if something works for us.

@jsenko jsenko merged commit 6ea275b into Apicurio:main Oct 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants