From 7d53a592efc16624646b682c55cce6c08cd198da Mon Sep 17 00:00:00 2001
From: Robin Candau <robincandau@protonmail.com>
Date: Wed, 22 Jan 2025 17:18:50 +0100
Subject: [PATCH] feat: Update / Improve desktop files (#72)

Add a Comment and Categories to desktop files + use the hicolor-icon specification for the icon
---
 Makefile                                               | 6 +++---
 res/desktop/ankama-launcher-container.desktop          | 6 ++++--
 res/desktop/ankama-launcher-container_rootless.desktop | 6 ++++--
 res/desktop/ankama-launcher-container_steamos.desktop  | 6 ++++--
 res/{icon => icons}/ankama-launcher-container.svg      | 0
 5 files changed, 15 insertions(+), 9 deletions(-)
 rename res/{icon => icons}/ankama-launcher-container.svg (100%)

diff --git a/Makefile b/Makefile
index 60f42bf..1e7928d 100644
--- a/Makefile
+++ b/Makefile
@@ -9,17 +9,17 @@ all:
 install:
 	install -Dm 755 "src/${pkgname}.sh" "${DESTDIR}${PREFIX}/bin/${pkgname}"
 	install -Dm 644 "res/desktop/${pkgname}.desktop" "${DESTDIR}${PREFIX}/share/applications/${pkgname}.desktop"
-	install -Dm 644 "res/icon/${pkgname}.svg" "${DESTDIR}/usr/share/icons/${pkgname}/${pkgname}.svg"
+	install -Dm 664 "res/icons/${pkgname}.svg" "${DESTDIR}${PREFIX}/share/icons/hicolor/scalable/apps/${pkgname}.svg"
 	install -Dm 644 README.md "${DESTDIR}${PREFIX}/share/doc/${pkgname}/README.md"
 
 install-rootless:
 	install -Dm 755 "src/${pkgname}_rootless.sh" "${DESTDIR}${PREFIX}/bin/${pkgname}"
 	install -Dm 644 "res/desktop/${pkgname}_rootless.desktop" "${DESTDIR}${PREFIX}/share/applications/${pkgname}.desktop"
-	install -Dm 644 "res/icon/${pkgname}.svg" "${DESTDIR}/usr/share/icons/${pkgname}/${pkgname}.svg"
+	install -Dm 664 "res/icons/${pkgname}.svg" "${DESTDIR}${PREFIX}/share/icons/hicolor/scalable/apps/${pkgname}.svg"
 	install -Dm 644 README.md "${DESTDIR}${PREFIX}/share/doc/${pkgname}/README.md"
 
 uninstall:
 	rm -f "${DESTDIR}${PREFIX}/bin/${pkgname}"
-	rm -rf "${DESTDIR}/usr/share/icons/${pkgname}/" 
+	rm -r "${DESTDIR}${PREFIX}/share/icons/hicolor/scalable/apps/${pkgname}.svg"
 	rm -f "${DESTDIR}${PREFIX}/share/applications/${pkgname}.desktop"
 	rm -rf "${DESTDIR}${PREFIX}/share/doc/${pkgname}/"
diff --git a/res/desktop/ankama-launcher-container.desktop b/res/desktop/ankama-launcher-container.desktop
index f6ed270..97ae987 100644
--- a/res/desktop/ankama-launcher-container.desktop
+++ b/res/desktop/ankama-launcher-container.desktop
@@ -1,6 +1,8 @@
 [Desktop Entry]
+Name=Ankama Launcher Container
+Comment=A distrobox container to run the Ankama launcher and games
+Icon=ankama-launcher-container
 Type=Application
 Terminal=true
-Name=Ankama Launcher Container
-Icon=/usr/share/icons/ankama-launcher-container/ankama-launcher-container.svg
 Exec=ankama-launcher-container
+Categories=Game
diff --git a/res/desktop/ankama-launcher-container_rootless.desktop b/res/desktop/ankama-launcher-container_rootless.desktop
index 8baa2ab..5706a60 100644
--- a/res/desktop/ankama-launcher-container_rootless.desktop
+++ b/res/desktop/ankama-launcher-container_rootless.desktop
@@ -1,5 +1,7 @@
 [Desktop Entry]
-Type=Application
 Name=Ankama Launcher Container
-Icon=/usr/share/icons/ankama-launcher-container/ankama-launcher-container.svg
+Comment=A distrobox container to run the Ankama launcher and games
+Icon=ankama-launcher-container
+Type=Application
 Exec=ankama-launcher-container
+Categories=Game
diff --git a/res/desktop/ankama-launcher-container_steamos.desktop b/res/desktop/ankama-launcher-container_steamos.desktop
index 31ccf31..9b89d73 100644
--- a/res/desktop/ankama-launcher-container_steamos.desktop
+++ b/res/desktop/ankama-launcher-container_steamos.desktop
@@ -1,5 +1,7 @@
 [Desktop Entry]
-Type=Application
 Name=Ankama Launcher Container
+Comment=A distrobox container to run the Ankama launcher and games
 Icon=/home/deck/.local/share/icons/ankama-launcher-container/ankama-launcher-container.svg
-Exec=bash -c 'export PATH="$HOME/.local/bin:$HOME/.local/podman/bin:$PATH" && ankama-launcher-container'
+Type=Application
+Exec=bash -c 'PATH="$HOME/.local/bin:$HOME/.local/podman/bin:$PATH" && ankama-launcher-container'
+Categories=Game
diff --git a/res/icon/ankama-launcher-container.svg b/res/icons/ankama-launcher-container.svg
similarity index 100%
rename from res/icon/ankama-launcher-container.svg
rename to res/icons/ankama-launcher-container.svg