From 1cb0752eb76a7db8305b408fc4db930656edaa7a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Rivet?=
 <Marc-Andre-Rivet@users.noreply.github.com>
Date: Mon, 4 Mar 2019 13:27:59 -0500
Subject: [PATCH] Improve build (#473)

---
 packages/dash-core-components/.eslintrc                  | 1 -
 .../dash_core_components/package.json                    | 8 ++++----
 .../src/components/Checklist.react.js                    | 4 +++-
 .../src/components/ConfirmDialogProvider.react.js        | 4 +++-
 .../src/components/DatePickerRange.react.js              | 4 +++-
 .../src/components/DatePickerSingle.react.js             | 4 +++-
 .../src/components/Dropdown.react.js                     | 4 +++-
 .../dash-core-components/src/components/Graph.react.js   | 4 +++-
 .../dash-core-components/src/components/Input.react.js   | 4 +++-
 .../dash-core-components/src/components/Link.react.js    | 4 +++-
 .../src/components/LogoutButton.react.js                 | 4 +++-
 .../src/components/Markdown.react.js                     | 3 ++-
 .../src/components/RadioItems.react.js                   | 4 +++-
 .../src/components/RangeSlider.react.js                  | 4 +++-
 .../dash-core-components/src/components/Slider.react.js  | 4 +++-
 .../src/components/SyntaxHighlighter.react.js            | 4 +++-
 .../dash-core-components/src/components/Tabs.react.js    | 9 ++++++---
 .../src/components/Textarea.react.js                     | 4 +++-
 .../dash-core-components/src/components/Upload.react.js  | 4 +++-
 19 files changed, 57 insertions(+), 24 deletions(-)

diff --git a/packages/dash-core-components/.eslintrc b/packages/dash-core-components/.eslintrc
index 7595ee0315..67c859a4b7 100644
--- a/packages/dash-core-components/.eslintrc
+++ b/packages/dash-core-components/.eslintrc
@@ -87,7 +87,6 @@
     "no-sequences": ["error"],
     "no-shadow": ["off"],
     "no-throw-literal": ["error"],
-    "no-undefined": ["error"],
     "no-unused-expressions": ["error"],
     "no-use-before-define": ["error", "nofunc"],
     "no-useless-call": ["error"],
diff --git a/packages/dash-core-components/dash_core_components/package.json b/packages/dash-core-components/dash_core_components/package.json
index 606f021deb..568443aa03 100644
--- a/packages/dash-core-components/dash_core_components/package.json
+++ b/packages/dash-core-components/dash_core_components/package.json
@@ -12,7 +12,7 @@
   "homepage": "https://github.com/plotly/dash-core-components",
   "main": "src/index.js",
   "scripts": {
-    "prepare": "npm run build:all",
+    "prepare": "npm run build",
     "publish-all": "node scripts/publish.js",
     "start": "webpack-serve ./webpack.serve.config.js --open",
     "lint": "eslint src test",
@@ -28,9 +28,9 @@
     "build:js-dev": "webpack --mode development",
     "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && dash-generate-components ./src/components dash_core_components",
     "build:r": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && dash-generate-components ./src/components dash_core_components --r-prefix 'core'",
-    "build:all": "npm run build:js && npm run build:js-dev && npm run build:py",
-    "build:all-dev": "npm run build:js-dev && npm run build:py",
-    "build:watch": "watch 'npm run build:all' src"
+    "build": "npm run build:js && npm run build:js-dev && npm run build:py",
+    "build-dev": "npm run build:js-dev && npm run build:py",
+    "build:watch": "watch 'npm run build' src"
   },
   "author": "Chris Parmer <chris@plot.ly>",
   "license": "MIT",
diff --git a/packages/dash-core-components/src/components/Checklist.react.js b/packages/dash-core-components/src/components/Checklist.react.js
index 2f45a0e785..d19d7cc373 100644
--- a/packages/dash-core-components/src/components/Checklist.react.js
+++ b/packages/dash-core-components/src/components/Checklist.react.js
@@ -35,7 +35,9 @@ export default class Checklist extends Component {
 
         return (
             <div
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 id={id}
                 style={style}
                 className={className}
diff --git a/packages/dash-core-components/src/components/ConfirmDialogProvider.react.js b/packages/dash-core-components/src/components/ConfirmDialogProvider.react.js
index c5b389941b..41d889aed4 100644
--- a/packages/dash-core-components/src/components/ConfirmDialogProvider.react.js
+++ b/packages/dash-core-components/src/components/ConfirmDialogProvider.react.js
@@ -49,7 +49,9 @@ export default class ConfirmDialogProvider extends React.Component {
         return (
             <div
                 id={id}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 {realChild && realChild.length
                     ? realChild.map(wrapClick)
diff --git a/packages/dash-core-components/src/components/DatePickerRange.react.js b/packages/dash-core-components/src/components/DatePickerRange.react.js
index 36d6a9aa12..9d69e55cdd 100644
--- a/packages/dash-core-components/src/components/DatePickerRange.react.js
+++ b/packages/dash-core-components/src/components/DatePickerRange.react.js
@@ -136,7 +136,9 @@ export default class DatePickerRange extends Component {
                 id={id}
                 style={DatePickerWrapperStyles}
                 className={className}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 <DateRangePicker
                     daySize={day_size}
diff --git a/packages/dash-core-components/src/components/DatePickerSingle.react.js b/packages/dash-core-components/src/components/DatePickerSingle.react.js
index ae1fe825e8..4934bc7d9d 100644
--- a/packages/dash-core-components/src/components/DatePickerSingle.react.js
+++ b/packages/dash-core-components/src/components/DatePickerSingle.react.js
@@ -112,7 +112,9 @@ export default class DatePickerSingle extends Component {
                 id={id}
                 style={DatePickerWrapperStyles}
                 className={className}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 <SingleDatePicker
                     date={date}
diff --git a/packages/dash-core-components/src/components/Dropdown.react.js b/packages/dash-core-components/src/components/Dropdown.react.js
index 97c0615b2b..6ea44ee4c5 100644
--- a/packages/dash-core-components/src/components/Dropdown.react.js
+++ b/packages/dash-core-components/src/components/Dropdown.react.js
@@ -67,7 +67,9 @@ export default class Dropdown extends Component {
             <div
                 id={id}
                 style={style}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 <ReactDropdown
                     filterOptions={filterOptions}
diff --git a/packages/dash-core-components/src/components/Graph.react.js b/packages/dash-core-components/src/components/Graph.react.js
index c198b9aaec..0d4b73bff7 100644
--- a/packages/dash-core-components/src/components/Graph.react.js
+++ b/packages/dash-core-components/src/components/Graph.react.js
@@ -220,7 +220,9 @@ class PlotlyGraph extends Component {
             <div
                 key={id}
                 id={id}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 style={style}
                 className={className}
             />
diff --git a/packages/dash-core-components/src/components/Input.react.js b/packages/dash-core-components/src/components/Input.react.js
index a1208f2a35..b33bb21d9d 100644
--- a/packages/dash-core-components/src/components/Input.react.js
+++ b/packages/dash-core-components/src/components/Input.react.js
@@ -37,7 +37,9 @@ export default class Input extends Component {
             : this.state;
         return (
             <input
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 onChange={e => {
                     const newValue = e.target.value;
                     if (
diff --git a/packages/dash-core-components/src/components/Link.react.js b/packages/dash-core-components/src/components/Link.react.js
index 1cc39e641e..f52726250c 100644
--- a/packages/dash-core-components/src/components/Link.react.js
+++ b/packages/dash-core-components/src/components/Link.react.js
@@ -56,7 +56,9 @@ export default class Link extends Component {
          */
         return (
             <a
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 id={id}
                 className={className}
                 style={style}
diff --git a/packages/dash-core-components/src/components/LogoutButton.react.js b/packages/dash-core-components/src/components/LogoutButton.react.js
index 53eb50add9..7af0276057 100644
--- a/packages/dash-core-components/src/components/LogoutButton.react.js
+++ b/packages/dash-core-components/src/components/LogoutButton.react.js
@@ -51,7 +51,9 @@ export default class LogoutButton extends React.Component {
 
         return (
             <form
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 action={url}
                 method={submitMethod}
                 className="dash-logout-frame"
diff --git a/packages/dash-core-components/src/components/Markdown.react.js b/packages/dash-core-components/src/components/Markdown.react.js
index e411ff9065..888db8eed0 100644
--- a/packages/dash-core-components/src/components/Markdown.react.js
+++ b/packages/dash-core-components/src/components/Markdown.react.js
@@ -17,7 +17,8 @@ function DashMarkdown(props) {
         <div
             id={props.id}
             data-dash-is-loading={
-                props.loading_state && props.loading_state.is_loading
+                (props.loading_state && props.loading_state.is_loading) ||
+                undefined
             }
         >
             <Markdown
diff --git a/packages/dash-core-components/src/components/RadioItems.react.js b/packages/dash-core-components/src/components/RadioItems.react.js
index e0890dab3e..0c92f12cdc 100644
--- a/packages/dash-core-components/src/components/RadioItems.react.js
+++ b/packages/dash-core-components/src/components/RadioItems.react.js
@@ -40,7 +40,9 @@ export default class RadioItems extends Component {
         }
         return (
             <div
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 {...ids}
                 className={className}
                 style={style}
diff --git a/packages/dash-core-components/src/components/RangeSlider.react.js b/packages/dash-core-components/src/components/RangeSlider.react.js
index 075db26e5d..c0ee802f3f 100644
--- a/packages/dash-core-components/src/components/RangeSlider.react.js
+++ b/packages/dash-core-components/src/components/RangeSlider.react.js
@@ -22,7 +22,9 @@ export default class RangeSlider extends Component {
         const {value} = this.state;
         return (
             <Range
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 onChange={value => {
                     this.setState({value});
                     if (updatemode === 'drag') {
diff --git a/packages/dash-core-components/src/components/Slider.react.js b/packages/dash-core-components/src/components/Slider.react.js
index a40331e99f..9d415f3551 100644
--- a/packages/dash-core-components/src/components/Slider.react.js
+++ b/packages/dash-core-components/src/components/Slider.react.js
@@ -23,7 +23,9 @@ export default class Slider extends Component {
         return (
             <div
                 id={id}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 <ReactSlider
                     onChange={value => {
diff --git a/packages/dash-core-components/src/components/SyntaxHighlighter.react.js b/packages/dash-core-components/src/components/SyntaxHighlighter.react.js
index 57643a458b..17c5c4707c 100644
--- a/packages/dash-core-components/src/components/SyntaxHighlighter.react.js
+++ b/packages/dash-core-components/src/components/SyntaxHighlighter.react.js
@@ -27,7 +27,9 @@ export default function SyntaxHighlighter(props) {
     return (
         <div
             id={id}
-            data-dash-is-loading={loading_state && loading_state.is_loading}
+            data-dash-is-loading={
+                (loading_state && loading_state.is_loading) || undefined
+            }
         >
             <ReactSyntaxHighlighter style={style} {...omit(['theme'], props)} />
         </div>
diff --git a/packages/dash-core-components/src/components/Tabs.react.js b/packages/dash-core-components/src/components/Tabs.react.js
index 9449db5256..ad6d1af1fc 100644
--- a/packages/dash-core-components/src/components/Tabs.react.js
+++ b/packages/dash-core-components/src/components/Tabs.react.js
@@ -48,7 +48,9 @@ const EnhancedTab = ({
     }
     return (
         <div
-            data-dash-is-loading={loading_state && loading_state.is_loading}
+            data-dash-is-loading={
+                (loading_state && loading_state.is_loading) || undefined
+            }
             className={tabClassName}
             id={id}
             style={tabStyle}
@@ -264,8 +266,9 @@ export default class Tabs extends Component {
         return (
             <div
                 data-dash-is-loading={
-                    this.props.loading_state &&
-                    this.props.loading_state.is_loading
+                    (this.props.loading_state &&
+                        this.props.loading_state.is_loading) ||
+                    undefined
                 }
                 className={`${tabParentClass} ${this.props.parent_className ||
                     ''}`}
diff --git a/packages/dash-core-components/src/components/Textarea.react.js b/packages/dash-core-components/src/components/Textarea.react.js
index a4ff16deb1..9184ee5a96 100644
--- a/packages/dash-core-components/src/components/Textarea.react.js
+++ b/packages/dash-core-components/src/components/Textarea.react.js
@@ -22,7 +22,9 @@ export default class Textarea extends Component {
 
         return (
             <textarea
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
                 value={value}
                 onChange={e => {
                     this.setState({value: e.target.value});
diff --git a/packages/dash-core-components/src/components/Upload.react.js b/packages/dash-core-components/src/components/Upload.react.js
index 7413d5e874..5ae44b141d 100644
--- a/packages/dash-core-components/src/components/Upload.react.js
+++ b/packages/dash-core-components/src/components/Upload.react.js
@@ -68,7 +68,9 @@ export default class Upload extends Component {
         return (
             <div
                 id={id}
-                data-dash-is-loading={loading_state && loading_state.is_loading}
+                data-dash-is-loading={
+                    (loading_state && loading_state.is_loading) || undefined
+                }
             >
                 <Dropzone
                     onDrop={this.onDrop}