-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limits and slow download speed #4
Comments
Maybe the "official," recommendation should be to just download the files locally and then pass the local directory to the importer until the code is more robust? @AnKingMed |
I'm fine with that for now |
If I understand this correctly, I think we need to use oauth2 to download files. The rate limit is supposed to be enough for our purposes at 20,000 requests / 100sec (200req/s for all the users) If using oauth2 doesn't help, I'm not really sure what we can do to improve performance though. All three solutions(gzip, partial, batch) listed on the linked google page can't be applied to downloading image files. Apparantly gzips don't do much for images as they are already compressed. Batch can't be used either.
|
Maybe we could have a compressed folder of images and download that? |
I think one use case we have to consider is when new images are added to the collection. This could happen when new cards are added, or images replaced with better ones. The add-on is pretty efficient with downloading 10 new images out of 1000 existing right now. We could just prompt the user to download the folder via web browser if it detects more than 100 images. That'd achieve the same thing with a couple more clicks. Especially if local folder import is made to handle zip files. |
That's a good idea for now |
Can the add-on just handle the download via |
In the future that'd be nice, but this isn't necessary for launch |
Does the current key have oauth2 activated? |
No |
When downloading from google drive a response with this message was returned after some files were downloaded:
"We're sorry but your computer or network may be sending automated queries. To protect our users, we can't process your request right now."
Also the download is pretty slow (it took 3 minutes for 20 mbs).
Resources:
https://developers.google.com/drive/api/guides/performance
The text was updated successfully, but these errors were encountered: