Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Replacing eslint-plugin-react with eslint-react #189

Closed
Talent30 opened this issue Aug 3, 2024 · 4 comments
Closed

[Proposal] Replacing eslint-plugin-react with eslint-react #189

Talent30 opened this issue Aug 3, 2024 · 4 comments
Labels
invalid This doesn't seem right

Comments

@Talent30
Copy link

Talent30 commented Aug 3, 2024

eslint-react is a modern version of eslint-plugin-react
https://eslint-react.xyz/docs/faq
Rel1cx/eslint-react#85

I will send a PR shortly if @AndreaPontrandolfo likes this idea.

@AndreaPontrandolfo
Copy link
Owner

Hey @Talent30 !

Sheriff is already using @eslint-react/eslint-plugin, but just for a couple of rules that i find useful and are not covered by eslint-plugin-react.
That being said, at this stage i don't consider @eslint-react/eslint-plugin a replacement for eslint-plugin-react. It's a very interesting project but it is still young and is still growing, it will take a while to reach the level of maturity of a project like eslint-plugin-react.

In summary, Sheriff is already employing @eslint-react/eslint-plugin so no PR is needed, thank you anyway for the report.
I'm gonna close this now.

@AndreaPontrandolfo AndreaPontrandolfo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2024
@AndreaPontrandolfo AndreaPontrandolfo added the invalid This doesn't seem right label Aug 3, 2024
@lishaduck
Copy link
Contributor

@AndreaPontrandolfo, maybe move this to a discussion? I think that at some point, it'd be nice to swap over to @eslint-react, but stick with both for now, given that it's a maturity/compatibility issue. Just my 2¢.

@AndreaPontrandolfo
Copy link
Owner

So, one of the issues with this, is that @eslint-react/eslint-plugin isn't a drop-in replacement for eslint-plugin-react, as outlined here.
So transitioning wouldn't be trivial, and it's questionable whether it would be an objective improvement or not.

@lishaduck
Copy link
Contributor

So, one of the issues with this, is that @eslint-react/eslint-plugin isn't a drop-in replacement for eslint-plugin-react, as outlined here. So transitioning wouldn't be trivial.

Yeah, so maybe wait for v30? (Maybe make majors that're multiples of majorly major? I personally like RedwoodJS's Epochs concept.)

It's questionable whether it would be an objective improvement or not.

Maybe not yet, but at some point it will likely mature, and then it's a more flexible, feature-complete, and more maintained plugin.


Anyway, I still vote this becomes an "ideas" discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants