Add registry settings override. fix #872

Author: LiorBanai

Analogy/ApplicationSettings/UpdateSettingsUC.cs

@@ -42,7 +42,7 @@ private void LoadSettings()
         {
             cbUpdates.Properties.Items.AddRange(typeof(UpdateMode).GetDisplayValues().Values);
             cbUpdates.SelectedItem = UpdateManager.Instance.UpdateMode.GetDisplay();
-            if (AnalogyNonPersistSettings.Instance.DisableUpdatesByDataProvidersOverrides)
+            if (AnalogyNonPersistSettings.Instance.UpdateAreDisabled)
             {
                 lblDisableUpdates.Visible = true;
                 cbUpdates.Enabled = false;

Analogy/CommonChangeLog.cs

@@ -11,6 +11,7 @@ public static IEnumerable<AnalogyChangeLog> GetChangeLog()
         {
             return new List<AnalogyChangeLog>
             {
+                new AnalogyChangeLog("V4.5.1 - Add registry settings override. #872",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2021,02,13)),
                 new AnalogyChangeLog("V4.5.1 - [UI] Add additional skins #873",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2021,02,13)),
                 new AnalogyChangeLog("V4.5.1 - [Data providers] Add custom data provider notification mechanism #516",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2021,02,12)),
                 new AnalogyChangeLog("V4.5.1 - [UI] Do not load subfolders when root folder/drive is selected #868",AnalogChangeLogType.Improvement,"Lior Banai",new DateTime(2021,02,09)),

Analogy/Forms/MainForm.cs

@@ -241,7 +241,7 @@ private async void AnalogyMainForm_Load(object sender, EventArgs e)
                 btnErrors.Visibility = BarItemVisibility.Always;
             }
 
-            if (!AnalogyNonPersistSettings.Instance.DisableUpdatesByDataProvidersOverrides)
+            if (!AnalogyNonPersistSettings.Instance.UpdateAreDisabled)
             {
                 var (_, release) = await UpdateManager.Instance.CheckVersion(false);
                 if (release?.TagName != null && UpdateManager.Instance.NewestVersion != null)

Analogy/Forms/UpdateForm.Designer.cs

@@ -21,7 +21,7 @@ private void UpdateForm_Load(object sender, EventArgs e)
             lblLatestVersion.Text =
                 $"Latest version is: {(Updater.LastVersionChecked?.TagName == null ? "not checked" : Updater.LastVersionChecked.TagName)}";
 
-            if (AnalogyNonPersistSettings.Instance.DisableUpdatesByDataProvidersOverrides)
+            if (AnalogyNonPersistSettings.Instance.UpdateAreDisabled)
             {
                 AnalogyLogManager.Instance.LogWarning("Update is disabled", nameof(UpdateForm));
                 sbtnUpdateNow.Visible = false;

Analogy/Forms/UpdateForm.cs

@@ -1,9 +1,7 @@
-using System;
+using Microsoft.Win32;
+using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Analogy.Managers
 {
@@ -12,11 +10,32 @@ public class AnalogyNonPersistSettings
         private static readonly Lazy<AnalogyNonPersistSettings> _instance =
             new Lazy<AnalogyNonPersistSettings>(() => new AnalogyNonPersistSettings());
         public static AnalogyNonPersistSettings Instance { get; set; } = _instance.Value;
+        private static string AnalogyRegistryKey => @"SOFTWARE\Analogy.LogViewer";
         public List<string> AdditionalAssembliesDependenciesLocations { get; }
         public bool DisableUpdatesByDataProvidersOverrides { get; set; }
+        public bool DisableUpdateFromRegistry { get; set; }
+
+        public bool UpdateAreDisabled => DisableUpdateFromRegistry || DisableUpdatesByDataProvidersOverrides;
         public AnalogyNonPersistSettings()
         {
-            AdditionalAssembliesDependenciesLocations=new List<string>();
+            AdditionalAssembliesDependenciesLocations = new List<string>();
+            try
+            {
+                using (RegistryKey? key = Registry.LocalMachine.OpenSubKey(AnalogyRegistryKey))
+                {
+                    object? updateRegistryValue = key?.GetValue("DisableUpdates");
+                    if (updateRegistryValue != null && bool.TryParse(updateRegistryValue.ToString(), out var disable))
+                    {
+                        AnalogyLogger.Instance.LogInformation($"Disable mode: {disable}");
+                        DisableUpdateFromRegistry = disable;
+                    }
+                }
+            }
+            catch (Exception e)
+            {
+                AnalogyLogManager.Instance.LogError($"Error reading registry: {e}", nameof(AnalogyNonPersistSettings));
+            }
+
         }
 
         public void AddDependencyLocation(string path)
@@ -29,7 +48,7 @@ public void AddDependencyLocation(string path)
                 }
                 else
                 {
-                    AnalogyLogManager.Instance.LogWarning($"{path} already exist in dependencies list",nameof(AddDependencyLocation));
+                    AnalogyLogManager.Instance.LogWarning($"{path} already exist in dependencies list", nameof(AddDependencyLocation));
                 }
             }
             else

Analogy/Managers/AnalogyNonPersistSettings.cs

@@ -15,7 +15,6 @@
 using System.Linq;
 using System.Reflection;
 using System.Runtime.CompilerServices;
-using Microsoft.Win32;
 
 namespace Analogy
 {
@@ -26,7 +25,6 @@ public class UserSettingsManager
         private static readonly Lazy<UserSettingsManager> _instance =
             new Lazy<UserSettingsManager>(() => new UserSettingsManager());
 
-        private static string AnalogyRegistryKey => @"SOFTWARE\Analogy.LogViewer";
         private CommandLayout _ribbonStyle;
         private bool _enableFirstChanceException;
         public event EventHandler<bool> OnEnableFirstChanceExceptionChanged;
@@ -137,6 +135,7 @@ public CommandLayout RibbonStyle
         public bool ViewDetailedMessageWithHTML { get; set; }
 
         public SettingsMode SettingsMode { get; set; }
+
         public UserSettingsManager()
         {
             TryLoadPortableSettings();
@@ -483,7 +482,7 @@ private void DeletePortableSettings()
             {
                 try
                 {
-                   File.Delete(LocalSettingFileName);
+                    File.Delete(LocalSettingFileName);
                 }
                 catch (Exception e)
                 {