refactor(nginx): update user authentication checks to use empty string for undefined tokens

Author: alimd

packages/nginx/etc/nginx/templates/location.d/55-region-public.conf.template

@@ -2,8 +2,9 @@
 # Nitrobase file location that can be accessed by anyone.
 
 location /$nitrobaseRegionPublic/ {
-  if ($authUserToken = 0) {
-    return 403; # User not defined
+  if ($authUserToken = "") {
+    # User not defined
+    return 403;
     break;
   }
 

packages/nginx/etc/nginx/templates/location.d/56-region-authenticated.conf.template

@@ -2,12 +2,14 @@
 # Nitrobase file location that can be accessed by authenticated users.
 
 location /$nitrobaseRegionAuthenticated/ {
-  if ($authUserToken = 0) {
-    return 403; # User not defined
+  if ($authUserToken = "") {
+    # User not defined
+    return 403;
     break;
   }
 
   if (!-f $document_root/$userLocation/.token/$authUserToken.asn) {
+    # Token file not found then user not authenticated
     return 403;
     break;
   }

packages/nginx/etc/nginx/templates/location.d/57-region-managers.conf.template

@@ -2,17 +2,20 @@
 # Nitrobase file location that can be accessed by admin and managers only.
 
 location /$nitrobaseRegionManagers/ {
-  if ($authUserToken = 0) {
-    return 403; # User not defined
+  if ($authUserToken = "") {
+    # User not defined
+    return 403;
     break;
   }
 
   if (!-f $document_root/$userLocation/.token/$authUserToken.asn) {
+    # Token file not found then user not authenticated
     return 403;
     break;
   }
 
   if (!-f $document_root/$userLocation/.auth/manager.asn) {
+    # Manager authentication file not found then user not a manager
     return 403;
     break;
   }

packages/nginx/etc/nginx/templates/location.d/58-region-per-user.conf.template

@@ -3,25 +3,30 @@
 
 location ~ ^/(?<requestLocation>$nitrobaseRegionPerUser/[A-z0-9_=-]+/[A-z0-9_=-]+)/ {
 
-  if ($authUserToken = 0) {
-    return 403; # User not defined
+  if ($authUserToken = "") {
+    # User not defined
+    return 403;
     break;
   }
 
   if (!-f $document_root/$userLocation/.token/$authUserToken.asn) {
+    # Token file not found then user not authenticated
     return 403;
     break;
   }
 
   try_files $uri =404;
 
   if (-f $document_root/$userLocation/.auth/manager.asn) {
+    # Manager authentication file found then user is a manager and can access other user's files
     break;
   }
 
   if ($userLocation = $requestLocation) {
+    # User requested his own files
     break;
   }
 
+  # User requested other user's files and is not a manager
   return 403;
 }

packages/nginx/etc/nginx/templates/location.d/59-region-per-owner.conf.template

@@ -2,7 +2,7 @@
 # Nitrobase file location specific to each owner id.
 
 location ~ ^/$nitrobaseRegionPerOwner/[A-z0-9_=-]+/[A-z0-9_=-]+/ {
-  if ($authUserToken = 0) {
+  if ($authUserToken = "") {
     return 403; # User not defined
     break;
   }